Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: components/sessions/BUILD.gn

Issue 673843002: Splits components/sessions into separate core and content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clobber. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/features.gni")
6 import("//third_party/protobuf/proto_library.gni")
7 import("//tools/grit/grit_rule.gni")
8
5 if (is_android) { 9 if (is_android) {
6 import("//build/config/android/config.gni") 10 import("//build/config/android/config.gni")
7 } 11 }
8 12
9 component("sessions") { 13 if (is_component_build) {
10 sources = [ 14 component("sessions") {
11 # TODO(rohitrao): Split this target into three separate core, content, 15 deps = [
12 # and web targets. 16 "//components/sessions/core",
13 "content/content_serialized_navigation_builder.cc", 17 ]
14 "content/content_serialized_navigation_builder.h",
15 "content/content_serialized_navigation_driver.cc",
16 "content/content_serialized_navigation_driver.h",
17 "core/serialized_navigation_driver.h",
18 "serialized_navigation_entry.cc",
19 "serialized_navigation_entry.h",
20 "session_id.cc",
21 "session_id.h",
22 ]
23 18
24 defines = [ "SESSIONS_IMPLEMENTATION" ] 19 if (!is_ios) {
20 deps += [ "//components/sessions/content" ]
21 }
22 }
23 group("sessions_core") {
blundell 2014/10/24 07:23:14 What is this?
rohitrao (ping after 24h) 2014/10/24 12:18:29 I'm not really sure, I copied it from components/p
24 deps = [ ":sessions" ]
25 }
25 26
26 deps = [ 27 if (!is_ios) {
27 "//base", 28 group("sessions_content") {
blundell 2014/10/24 07:23:13 and this?
28 "//base/third_party/dynamic_annotations", 29 deps = [ ":sessions" ]
29 "//content/public/browser", 30 }
30 "//skia", 31 }
31 "//ui/base", 32 } else { # Compile to separate libraries.
32 "//url", 33 group("sessions") {
33 ] 34 deps = [
35 ":sessions_core",
36 ":sessions_content",
37 ]
34 38
35 if (!is_android || !is_android_webview_build) { 39 if (!is_ios) {
36 deps += [ "//sync" ] 40 deps += [ ":sessions_content" ]
41 }
42 }
43 component("sessions_core") {
44 deps = [ "//components/sessions/core" ]
45 }
46
47 if (!is_ios) {
48 component("sessions_content") {
49 deps = [ "//components/sessions/content" ]
50 }
37 } 51 }
38 } 52 }
39 53
54
40 static_library("test_support") { 55 static_library("test_support") {
41 testonly = true 56 testonly = true
42 sources = [ 57 sources = [
43 "serialized_navigation_entry_test_helper.cc", 58 "serialized_navigation_entry_test_helper.cc",
44 "serialized_navigation_entry_test_helper.h", 59 "serialized_navigation_entry_test_helper.h",
45 ] 60 ]
46 61
47 deps = [ 62 deps = [
48 "//skia", 63 "//skia",
49 "//testing/gtest", 64 "//testing/gtest",
50 ] 65 ]
51 66
52 if (!is_android || !is_android_webview_build) { 67 if (!is_android || !is_android_webview_build) {
53 deps += [ "//sync" ] 68 deps += [ "//sync" ]
54 } 69 }
55 } 70 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698