Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: components/sessions/BUILD.gn

Issue 673843002: Splits components/sessions into separate core and content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/BUILD.gn
diff --git a/components/sessions/BUILD.gn b/components/sessions/BUILD.gn
index f2ada0545aee1890d319f722324ae5c0f51b0e5d..a0523987927104015cdccb33c6d715f1c404c2cf 100644
--- a/components/sessions/BUILD.gn
+++ b/components/sessions/BUILD.gn
@@ -6,14 +6,8 @@ if (is_android) {
import("//build/config/android/config.gni")
}
-component("sessions") {
+source_set("sessions_core") {
blundell 2014/10/24 14:10:42 I would have an explanation here also of why this
sources = [
- # TODO(rohitrao): Split this target into three separate core, content,
- # and web targets.
- "content/content_serialized_navigation_builder.cc",
- "content/content_serialized_navigation_builder.h",
- "content/content_serialized_navigation_driver.cc",
- "content/content_serialized_navigation_driver.h",
"core/serialized_navigation_driver.h",
"serialized_navigation_entry.cc",
"serialized_navigation_entry.h",
@@ -25,8 +19,6 @@ component("sessions") {
deps = [
"//base",
- "//base/third_party/dynamic_annotations",
- "//content/public/browser",
"//skia",
"//ui/base",
"//url",
@@ -37,6 +29,26 @@ component("sessions") {
}
}
+component("sessions_content") {
+ sources = [
+ "content/content_serialized_navigation_builder.cc",
+ "content/content_serialized_navigation_builder.h",
+ "content/content_serialized_navigation_driver.cc",
+ "content/content_serialized_navigation_driver.h",
+ ]
+
+ defines = [ "SESSIONS_IMPLEMENTATION" ]
+
+ deps = [
+ ":sessions_core",
+ "//base",
+ "//base/third_party/dynamic_annotations",
+ "//content/public/browser",
+ "//ui/base",
+ "//url",
+ ]
+}
+
static_library("test_support") {
testonly = true
sources = [

Powered by Google App Engine
This is Rietveld 408576698