Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: components/sessions/BUILD.gn

Issue 673843002: Splits components/sessions into separate core and content targets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix GN. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (is_android) { 5 if (is_android) {
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 } 7 }
8 8
9 component("sessions") { 9 source_set("sessions_core") {
blundell 2014/10/24 14:10:42 I would have an explanation here also of why this
10 sources = [ 10 sources = [
11 # TODO(rohitrao): Split this target into three separate core, content,
12 # and web targets.
13 "content/content_serialized_navigation_builder.cc",
14 "content/content_serialized_navigation_builder.h",
15 "content/content_serialized_navigation_driver.cc",
16 "content/content_serialized_navigation_driver.h",
17 "core/serialized_navigation_driver.h", 11 "core/serialized_navigation_driver.h",
18 "serialized_navigation_entry.cc", 12 "serialized_navigation_entry.cc",
19 "serialized_navigation_entry.h", 13 "serialized_navigation_entry.h",
20 "session_id.cc", 14 "session_id.cc",
21 "session_id.h", 15 "session_id.h",
22 ] 16 ]
23 17
24 defines = [ "SESSIONS_IMPLEMENTATION" ] 18 defines = [ "SESSIONS_IMPLEMENTATION" ]
25 19
26 deps = [ 20 deps = [
27 "//base", 21 "//base",
28 "//base/third_party/dynamic_annotations",
29 "//content/public/browser",
30 "//skia", 22 "//skia",
31 "//ui/base", 23 "//ui/base",
32 "//url", 24 "//url",
33 ] 25 ]
34 26
35 if (!is_android || !is_android_webview_build) { 27 if (!is_android || !is_android_webview_build) {
36 deps += [ "//sync" ] 28 deps += [ "//sync" ]
37 } 29 }
38 } 30 }
39 31
32 component("sessions_content") {
33 sources = [
34 "content/content_serialized_navigation_builder.cc",
35 "content/content_serialized_navigation_builder.h",
36 "content/content_serialized_navigation_driver.cc",
37 "content/content_serialized_navigation_driver.h",
38 ]
39
40 defines = [ "SESSIONS_IMPLEMENTATION" ]
41
42 deps = [
43 ":sessions_core",
44 "//base",
45 "//base/third_party/dynamic_annotations",
46 "//content/public/browser",
47 "//ui/base",
48 "//url",
49 ]
50 }
51
40 static_library("test_support") { 52 static_library("test_support") {
41 testonly = true 53 testonly = true
42 sources = [ 54 sources = [
43 "serialized_navigation_entry_test_helper.cc", 55 "serialized_navigation_entry_test_helper.cc",
44 "serialized_navigation_entry_test_helper.h", 56 "serialized_navigation_entry_test_helper.h",
45 ] 57 ]
46 58
47 deps = [ 59 deps = [
48 "//skia", 60 "//skia",
49 "//testing/gtest", 61 "//testing/gtest",
50 ] 62 ]
51 63
52 if (!is_android || !is_android_webview_build) { 64 if (!is_android || !is_android_webview_build) {
53 deps += [ "//sync" ] 65 deps += [ "//sync" ]
54 } 66 }
55 } 67 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698