Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 673753004: Move RenderSVGResource into the inheritance hierarchy (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Move RenderSVGResource into the inheritance hierarchy With RenderSVGResource reduced to a common base for paint-servers, it's possible to get rid of the multiple inheritance on RenderSVGResourceContainer by instead making it the base of RenderSVGResource{Gradient,Pattern} while inheriting from RenderSVGResourceContainer. Rename the files appropriately and update existing references to RenderSVGResource. Also take the opportunity to tighten the types a bit in some places. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184278

Patch Set 1 #

Patch Set 2 : Non-move changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -355 lines) Patch
M Source/core/core.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/paint/SVGInlineTextBoxPainter.h View 1 1 chunk +1 line, -1 line 0 comments Download
D Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +0 lines, -89 lines 0 comments Download
D Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +0 lines, -192 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceContainer.h View 1 4 chunks +11 lines, -5 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
A + Source/core/rendering/svg/RenderSVGResourcePaintServer.h View 1 3 chunks +13 lines, -10 lines 0 comments Download
A + Source/core/rendering/svg/RenderSVGResourcePaintServer.cpp View 1 3 chunks +9 lines, -7 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderSupport.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGRenderTreeAsText.cpp View 1 3 chunks +7 lines, -9 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.h View 1 4 chunks +7 lines, -6 lines 0 comments Download
M Source/core/rendering/svg/SVGResources.cpp View 1 9 chunks +12 lines, -20 lines 0 comments Download
M Source/core/rendering/svg/SVGResourcesCycleSolver.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
fs
6 years, 2 months ago (2014-10-23 13:18:40 UTC) #2
f(malita)
Thanks for pursuing this cleanup, LGTM!
6 years, 2 months ago (2014-10-23 13:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673753004/20001
6 years, 2 months ago (2014-10-23 14:20:02 UTC) #5
fs
On 2014/10/23 13:48:11, Florin Malita wrote: > Thanks for pursuing this cleanup, LGTM! @fmalita: This ...
6 years, 2 months ago (2014-10-23 14:24:43 UTC) #9
f(malita)
On 2014/10/23 14:24:43, fs wrote: > On 2014/10/23 13:48:11, Florin Malita wrote: > > Thanks ...
6 years, 2 months ago (2014-10-23 14:27:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673753004/20001
6 years, 2 months ago (2014-10-23 15:31:19 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 15:32:27 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184278

Powered by Google App Engine
This is Rietveld 408576698