Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 67373005: win: Fix behaviour of MinimumRequiredVersion (Closed)

Created:
7 years, 1 month ago by scottmg
Modified:
7 years, 1 month ago
Reviewers:
Nico
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

win: Fix behaviour of MinimumRequiredVersion Previous change for ninja set default subsystem to XP, but didn't do anything for msvs. This broke the 2012 bot which is where the default changed (I thought it was 2013 previously). Now, use the MinimumRequiredVersion setting to determine this value, which works in VS >= 2010 and emulate that in ninja. Also, add another line to TestGyp.py so that gyptest.py works when running on VS2013. R=thakis@chromium.org BUG=320371 Committed: https://code.google.com/p/gyp/source/detail?r=1788

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M pylib/gyp/MSVSSettings.py View 2 chunks +1 line, -1 line 0 comments Download
M pylib/gyp/msvs_emulation.py View 1 chunk +6 lines, -7 lines 0 comments Download
M test/lib/TestGyp.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/win/gyptest-link-subsystem.py View 1 chunk +4 lines, -2 lines 0 comments Download
M test/win/linker-flags/subsystem.gyp View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
7 years, 1 month ago (2013-11-17 22:15:25 UTC) #1
Nico
lgtm, thanks!
7 years, 1 month ago (2013-11-17 22:23:58 UTC) #2
scottmg
7 years, 1 month ago (2013-11-17 22:46:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r1788.

Powered by Google App Engine
This is Rietveld 408576698