Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: test/win/gyptest-link-subsystem.py

Issue 67373005: win: Fix behaviour of MinimumRequiredVersion (Closed) Base URL: http://gyp.googlecode.com/svn/trunk
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/lib/TestGyp.py ('k') | test/win/linker-flags/subsystem.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/win/gyptest-link-subsystem.py
diff --git a/test/win/gyptest-link-subsystem.py b/test/win/gyptest-link-subsystem.py
index de3fb799146dce549017b244d3cb4d19eff84597..a94ba36856bac82183032c612971670d786cfb02 100644
--- a/test/win/gyptest-link-subsystem.py
+++ b/test/win/gyptest-link-subsystem.py
@@ -23,12 +23,14 @@ if sys.platform == 'win32':
test.build('subsystem.gyp', 'test_windows_ok', chdir=CHDIR)
test.build('subsystem.gyp', 'test_windows_fail', chdir=CHDIR, status=1)
+ test.build('subsystem.gyp', 'test_console_xp', chdir=CHDIR)
+ test.build('subsystem.gyp', 'test_windows_xp', chdir=CHDIR)
# Make sure we are targeting XP.
def GetHeaders(exe):
return test.run_dumpbin('/headers', test.built_file_path(exe, chdir=CHDIR))
- if '5.01 subsystem version' not in GetHeaders('test_console_ok.exe'):
+ if '5.01 subsystem version' not in GetHeaders('test_console_xp.exe'):
test.fail_test()
- if '5.01 subsystem version' not in GetHeaders('test_windows_ok.exe'):
+ if '5.01 subsystem version' not in GetHeaders('test_windows_xp.exe'):
test.fail_test()
# TODO(scottmg): There are other subsystems (WinCE, etc.) that we don't use.
« no previous file with comments | « test/lib/TestGyp.py ('k') | test/win/linker-flags/subsystem.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698