Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 673723002: Deterministic recipe: Print the list of files for which zap_timestamp failed. (Closed)

Created:
6 years, 2 months ago by Sébastien Marchand
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Deterministic recipe: Print the list of files for which zap_timestamp failed. BUG=314403 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292608

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py View 1 2 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Sébastien Marchand
PTAL.
6 years, 2 months ago (2014-10-23 01:56:54 UTC) #3
M-A Ruel
lgtm https://codereview.chromium.org/673723002/diff/20001/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py File scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py (right): https://codereview.chromium.org/673723002/diff/20001/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py#newcode47 scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py:47: add a "return 0" at the end of ...
6 years, 2 months ago (2014-10-23 02:01:21 UTC) #4
Sébastien Marchand
Thanks, committing. https://codereview.chromium.org/673723002/diff/20001/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py File scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py (right): https://codereview.chromium.org/673723002/diff/20001/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py#newcode47 scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py:47: On 2014/10/23 02:01:21, M-A Ruel wrote: > ...
6 years, 2 months ago (2014-10-23 02:03:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673723002/40001
6 years, 2 months ago (2014-10-23 02:04:37 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 02:05:54 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as 292608

Powered by Google App Engine
This is Rietveld 408576698