Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py

Issue 673723002: Deterministic recipe: Print the list of files for which zap_timestamp failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
diff --git a/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py b/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
index 77169e8a1eec94d27e67c55752b2df643c2c6656..fd34ae8b26cb0405a0494dd438cdca2754d90456 100644
--- a/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
+++ b/scripts/slave/recipe_modules/isolate/resources/remove_build_metadata.py
@@ -28,6 +28,7 @@ def RemovePEMetadata(build_dir, src_dir):
with open(os.path.join(BASE_DIR, 'deterministic_build_blacklist.json')) as f:
blacklist = frozenset(json.load(f))
+ failed = []
for filename in files:
# Ignore the blacklisted files.
if filename in blacklist:
@@ -37,8 +38,14 @@ def RemovePEMetadata(build_dir, src_dir):
if os.path.exists(os.path.join(build_dir, filename + '.pdb')):
ret = RunZapTimestamp(src_dir, os.path.join(build_dir, filename))
if ret != 0:
- print "zap_timestamp.exe failed for %s." % filename
- return ret
+ failed.append(filename)
+
+ if failed:
+ print >> sys.stderr, 'zap_timestamp.exe failed for the following files:'
+ print >> sys.stderr, '\n'.join(' ' + i for i in sorted(failed))
+ return 1
+
+ return 0
def main():
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698