Chromium Code Reviews
Help | Chromium Project | Sign in
(77)

Issue 6736006: Check for SSE2 support in FullCodeGenerator::EmitMathPow. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 1 month ago by Vyacheslav Egorov
Modified:
2 years, 9 months ago
CC:
v8-dev_googlegroups.com
Visibility:
Public.

Description

Check for SSE2 support in FullCodeGenerator::EmitMathPow.

Do not emit call to the MathPowStub when SSE2 is not available because it requires SSE2.

Committed: http://code.google.com/p/v8/source/detail?r=7366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Lint Patch
M src/ia32/full-codegen-ia32.cc View 1 chunk +6 lines, -2 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
Vyacheslav Egorov
3 years, 1 month ago #1
Mads Ager (chromium)
LGTM
3 years, 1 month ago #2
bminer
2 years, 9 months ago #3
Please fix this in a branch other than "bleeding_edge". It is causing a bug in
Node.JS.

https://github.com/joyent/node/issues/829
https://github.com/joyent/node/pull/830
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6