Chromium Code Reviews
Help | Chromium Project | Sign in
(58)

Issue 6736006: Check for SSE2 support in FullCodeGenerator::EmitMathPow. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 3 months ago by Vyacheslav Egorov
Modified:
3 years, 12 months ago
CC:
v8-dev
Visibility:
Public.

Description

Check for SSE2 support in FullCodeGenerator::EmitMathPow. Do not emit call to the MathPowStub when SSE2 is not available because it requires SSE2. Committed: http://code.google.com/p/v8/source/detail?r=7366

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M src/ia32/full-codegen-ia32.cc View 1 chunk +6 lines, -2 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov
4 years, 3 months ago (2011-03-24 20:25:21 UTC) #1
Mads Ager (chromium)
LGTM
4 years, 3 months ago (2011-03-25 08:38:09 UTC) #2
bminer
3 years, 12 months ago (2011-07-08 02:28:20 UTC) #3
Please fix this in a branch other than "bleeding_edge". It is causing a bug in
Node.JS.

https://github.com/joyent/node/issues/829
https://github.com/joyent/node/pull/830
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d