Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1125)

Unified Diff: Source/core/rendering/RenderTableSection.cpp

Issue 673533002: Table rows are not totally invalidated after r170349 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update first comment after Dan's review (forgot to do it) Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/RenderTableRow.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderTableSection.cpp
diff --git a/Source/core/rendering/RenderTableSection.cpp b/Source/core/rendering/RenderTableSection.cpp
index 21279898296f230b6f76c4d33b7c69fd928d28e7..4a3b46a5ca8aacf06bea364979ea45a050230474 100644
--- a/Source/core/rendering/RenderTableSection.cpp
+++ b/Source/core/rendering/RenderTableSection.cpp
@@ -955,7 +955,8 @@ void RenderTableSection::layoutRows()
for (unsigned r = 0; r < totalRows; r++) {
// Set the row's x/y position and width/height.
- if (RenderTableRow* rowRenderer = m_grid[r].rowRenderer) {
+ RenderTableRow* rowRenderer = m_grid[r].rowRenderer;
+ if (rowRenderer) {
rowRenderer->setLocation(LayoutPoint(0, m_rowPos[r]));
rowRenderer->setLogicalWidth(logicalWidth());
rowRenderer->setLogicalHeight(m_rowPos[r + 1] - m_rowPos[r] - vspacing);
@@ -1053,6 +1054,9 @@ void RenderTableSection::layoutRows()
cell->computeOverflow(oldLogicalHeight, false);
}
+ if (rowRenderer)
+ rowRenderer->addOverflowFromCell(cell);
+
LayoutSize childOffset(cell->location() - oldCellRect.location());
if (childOffset.width() || childOffset.height()) {
// If the child moved, we have to issue paint invalidations to it as well as any floating/positioned
« no previous file with comments | « Source/core/rendering/RenderTableRow.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698