Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 673443002: [Mac] Shut down connections to WindowServer before engaging the sandbox. (Closed)

Created:
6 years, 2 months ago by Robert Sesek
Modified:
6 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Mac] Shut down connections to WindowServer before engaging the sandbox. This is only done for Mac OS versions 10.8 and higher. A similar CL was landed and reverted: https://chromium.googlesource.com/chromium/src.git/+/cef0cb9e60fb0f47562be83f8aa117899f0314d5 BUG=397642, 306348 TEST=Manually tested on 10.6-10.10. R=avi@chromium.org, jeremy@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/4842a0e08daada491fc519b9eade2cfd04f804ed

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -2 lines) Patch
M content/common/sandbox_mac.mm View 1 3 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Robert Sesek
avi/jeremy: Whichever one of you sees it first, please. You've both seen it before :).
6 years, 2 months ago (2014-10-21 23:17:25 UTC) #2
Avi (use Gerrit)
lgtm https://codereview.chromium.org/673443002/diff/1/content/common/sandbox_mac.mm File content/common/sandbox_mac.mm (right): https://codereview.chromium.org/673443002/diff/1/content/common/sandbox_mac.mm#newcode338 content/common/sandbox_mac.mm:338: // so do this before actually engaging the ...
6 years, 2 months ago (2014-10-21 23:23:17 UTC) #3
jeremy
LGTM++ ! https://codereview.chromium.org/673443002/diff/1/content/common/sandbox_mac.mm File content/common/sandbox_mac.mm (right): https://codereview.chromium.org/673443002/diff/1/content/common/sandbox_mac.mm#newcode338 content/common/sandbox_mac.mm:338: // so do this before actually engaging ...
6 years, 2 months ago (2014-10-22 04:39:37 UTC) #4
Robert Sesek
https://codereview.chromium.org/673443002/diff/1/content/common/sandbox_mac.mm File content/common/sandbox_mac.mm (right): https://codereview.chromium.org/673443002/diff/1/content/common/sandbox_mac.mm#newcode338 content/common/sandbox_mac.mm:338: // so do this before actually engaging the sandbox. ...
6 years, 2 months ago (2014-10-23 14:44:23 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/4842a0e08daada491fc519b9eade2cfd04f804ed Cr-Commit-Position: refs/heads/master@{#300891}
6 years, 2 months ago (2014-10-23 15:14:45 UTC) #6
Robert Sesek
6 years, 2 months ago (2014-10-23 15:15:41 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4842a0e08daada491fc519b9eade2cfd04f804ed (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698