Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 673403002: Remove compiler feature detection for = delete (Closed)

Created:
6 years, 2 months ago by abarth-chromium
Modified:
6 years, 2 months ago
Reviewers:
esprehn, eseidel
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove compiler feature detection for = delete All supported compilers have this feature. Also remove unused macros for OVERRIDE now that override are broadly supported. R=esprehn@chromium.org, eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4a79057bf2165ecd8ed8d3c6d33294da33a85255

Patch Set 1 #

Patch Set 2 : Don't remove #define for FINAL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -95 lines) Patch
M sky/engine/core/dom/Attr.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/CharacterData.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/ContainerNode.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/dom/Document.h View 2 chunks +4 lines, -4 lines 0 comments Download
M sky/engine/core/dom/DocumentFragment.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/Element.h View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/dom/Text.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/dom/shadow/InsertionPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/editing/PlainTextRange.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/html/HTMLElement.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBlock.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/core/rendering/RenderInline.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderMedia.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/engine/core/rendering/RenderText.h View 1 chunk +1 line, -1 line 0 comments Download
M sky/engine/platform/heap/Heap.h View 2 chunks +0 lines, -23 lines 0 comments Download
M sky/engine/wtf/Compiler.h View 1 5 chunks +1 line, -26 lines 0 comments Download
M sky/engine/wtf/Noncopyable.h View 1 chunk +4 lines, -11 lines 0 comments Download
M sky/engine/wtf/NullPtr.h View 1 chunk +0 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
abarth-chromium
6 years, 2 months ago (2014-10-25 05:13:59 UTC) #1
esprehn
lgtm
6 years, 2 months ago (2014-10-25 06:04:16 UTC) #3
abarth-chromium
6 years, 2 months ago (2014-10-25 06:19:11 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
4a79057bf2165ecd8ed8d3c6d33294da33a85255.

Powered by Google App Engine
This is Rietveld 408576698