chrome/browser/resources/options/chromeos/preferred_networks.js - Issue 673313003: More changes to make network settings better match extension API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/preferred_networks.js

Issue 673313003: More changes to make network settings better match extension API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/network_list.js ('K') | « chrome/browser/resources/options/chromeos/network_list.js ('k') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.h » ('j') | chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/preferred_networks.js

diff --git a/chrome/browser/resources/options/chromeos/preferred_networks.js b/chrome/browser/resources/options/chromeos/preferred_networks.js

index 2234733329fdbf26ab933d775e6f8dc563b2d6b6..8dd24ecf06c69157a01eeebd294107b369855d19 100644

--- a/chrome/browser/resources/options/chromeos/preferred_networks.js

+++ b/chrome/browser/resources/options/chromeos/preferred_networks.js

@@ -126,11 +126,9 @@ cr.define('options', function() {

deleteItemAtIndex: function(index) {

var item = this.dataModel.item(index);

if (item) {

- // Inform the network library that we are forgetting this network.

- chrome.send('networkCommand',

- [item.Type,

- item.servicePath,

- 'forget']);

+ // TODO(stevenjb): Add removeNetwork to chrome.networkingPrivate and

+ // use that here.

+ chrome.send('removeNetwork', [item.servicePath]);

}

this.dataModel.splice(index, 1);

// Invalidate the list since it has a stale cache after a splice