Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 673243002: Rename Resource::willSendRequest() to willFollowRedirect() (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Rename Resource::willSendRequest() to willFollowRedirect() The method is for handling redirect response. It's confusing that this is given a name sounds like intercepting all requests. R=mkwst BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184377

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #4 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M Source/core/fetch/CachingCorrectnessTest.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/core/fetch/RawResource.h View 1 1 chunk +9 lines, -9 lines 0 comments Download
M Source/core/fetch/RawResource.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/core/fetch/Resource.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/Resource.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceLoader.h View 1 1 chunk +8 lines, -8 lines 0 comments Download
M Source/core/fetch/ResourceLoader.cpp View 1 chunk +11 lines, -11 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-24 15:17:27 UTC) #3
Mike West
LGTM, this is a nice readability improvement. https://codereview.chromium.org/673243002/diff/1/Source/core/fetch/ResourceLoader.h File Source/core/fetch/ResourceLoader.h (left): https://codereview.chromium.org/673243002/diff/1/Source/core/fetch/ResourceLoader.h#oldcode76 Source/core/fetch/ResourceLoader.h:76: virtual void ...
6 years, 2 months ago (2014-10-24 15:30:00 UTC) #4
tyoshino (SeeGerritForStatus)
https://codereview.chromium.org/673243002/diff/1/Source/core/fetch/ResourceLoader.h File Source/core/fetch/ResourceLoader.h (left): https://codereview.chromium.org/673243002/diff/1/Source/core/fetch/ResourceLoader.h#oldcode76 Source/core/fetch/ResourceLoader.h:76: virtual void willSendRequest(blink::WebURLLoader*, blink::WebURLRequest&, const blink::WebURLResponse& redirectResponse) override; On ...
6 years, 2 months ago (2014-10-24 16:57:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673243002/20001
6 years, 2 months ago (2014-10-24 16:58:30 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 18:05:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184377

Powered by Google App Engine
This is Rietveld 408576698