Source/core/fetch/ResourceLoader.h - Issue 673243002: Rename Resource::willSendRequest() to willFollowRedirect()

Side by Side Diff: Source/core/fetch/ResourceLoader.h

Issue 673243002: Rename Resource::willSendRequest() to willFollowRedirect() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « Source/core/fetch/Resource.cpp ('k') | Source/core/fetch/ResourceLoader.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2005, 2006, 2011 Apple Inc. All rights reserved.	2 * Copyright (C) 2005, 2006, 2011 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 *	7 *

8 * 1. Redistributions of source code must retain the above copyright	8 * 1. Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * 2. Redistributions in binary form must reproduce the above copyright	10 * 2. Redistributions in binary form must reproduce the above copyright

(...skipping 55 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
66 void setDefersLoading(bool);	66 void setDefersLoading(bool);

67 bool defersLoading() const { return m_defersLoading; }	67 bool defersLoading() const { return m_defersLoading; }

68	68

69 void attachThreadedDataReceiver(PassOwnPtr<blink::WebThreadedDataReceiver>);	69 void attachThreadedDataReceiver(PassOwnPtr<blink::WebThreadedDataReceiver>);

70	70

71 void releaseResources();	71 void releaseResources();

72	72

73 void didChangePriority(ResourceLoadPriority, int intraPriorityValue);	73 void didChangePriority(ResourceLoadPriority, int intraPriorityValue);

74	74

75 // WebURLLoaderClient	75 // WebURLLoaderClient

76 virtual void willSendRequest(blink::WebURLLoader*, blink::WebURLRequest&, co nst blink::WebURLResponse& redirectResponse) override;	76 void willSendRequest(blink::WebURLLoader*, blink::WebURLRequest&, const blin k::WebURLResponse& redirectResponse) override;
Mike West 2014/10/24 15:30:00 If you're going to drop the one `virtual`, please If you're going to drop the one `virtual`, please drop them all. :) tyoshino (SeeGerritForStatus) 2014/10/24 16:57:08 Ah, OK! Done. Show quoted text On 2014/10/24 15:30:00, Mike West wrote: > If you're going to drop the one `virtual`, please drop them all. :) Ah, OK! Done.
77 virtual void didSendData(blink::WebURLLoader*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;	77 virtual void didSendData(blink::WebURLLoader*, unsigned long long bytesSent, unsigned long long totalBytesToBeSent) override;

78 virtual void didReceiveResponse(blink::WebURLLoader*, const blink::WebURLRes ponse&) override;	78 virtual void didReceiveResponse(blink::WebURLLoader*, const blink::WebURLRes ponse&) override;

79 virtual void didReceiveData(blink::WebURLLoader, const char, int, int enco dedDataLength) override;	79 virtual void didReceiveData(blink::WebURLLoader, const char, int, int enco dedDataLength) override;

80 virtual void didReceiveCachedMetadata(blink::WebURLLoader, const char data , int length) override;	80 virtual void didReceiveCachedMetadata(blink::WebURLLoader, const char data , int length) override;

81 virtual void didFinishLoading(blink::WebURLLoader*, double finishTime, int64 encodedDataLength) override;	81 virtual void didFinishLoading(blink::WebURLLoader*, double finishTime, int64 encodedDataLength) override;

82 virtual void didFail(blink::WebURLLoader*, const blink::WebURLError&) overri de;	82 virtual void didFail(blink::WebURLLoader*, const blink::WebURLError&) overri de;

83 virtual void didDownloadData(blink::WebURLLoader*, int, int) override;	83 virtual void didDownloadData(blink::WebURLLoader*, int, int) override;

84	84

85 const KURL& url() const { return m_request.url(); }	85 const KURL& url() const { return m_request.url(); }

86 bool isLoadedBy(ResourceLoaderHost*) const;	86 bool isLoadedBy(ResourceLoaderHost*) const;

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
145 // Used for sanity checking to make sure we don't experience illegal state	145 // Used for sanity checking to make sure we don't experience illegal state

146 // transitions.	146 // transitions.

147 ConnectionState m_connectionState;	147 ConnectionState m_connectionState;

148	148

149 OwnPtr<RequestCountTracker> m_requestCountTracker;	149 OwnPtr<RequestCountTracker> m_requestCountTracker;

150 };	150 };

151	151

152 }	152 }

153	153

154 #endif	154 #endif

OLD	NEW