Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 673223002: Get SkV8Example running again. (Closed)

Created:
6 years, 2 months ago by jcgregorio
Modified:
6 years, 2 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Doing the "using namespace" penance by adding in v8:: everywhere, like I should have to begin with. Also: - SkWindow now has createSurface, not createCanvas. - Add the platform init code v8 now seems to require. - Fix library linkage. - Call isolate->Enter(); because it doesn't look like v8 starts with a default isolate to begin with. BUG=skia: Committed: https://skia.googlesource.com/skia/+/e22f45fd89ef70b2ba645c354e951365ab8540c7

Patch Set 1 #

Patch Set 2 : now linking #

Patch Set 3 : finally working #

Patch Set 4 : rebase #

Patch Set 5 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -186 lines) Patch
M experimental/SkV8Example/BaseContext.h View 2 chunks +26 lines, -28 lines 0 comments Download
M experimental/SkV8Example/BaseContext.cpp View 14 chunks +45 lines, -47 lines 0 comments Download
M experimental/SkV8Example/Global.h View 4 chunks +12 lines, -13 lines 0 comments Download
M experimental/SkV8Example/Global.cpp View 12 chunks +30 lines, -30 lines 0 comments Download
M experimental/SkV8Example/JsContext.h View 2 chunks +3 lines, -5 lines 0 comments Download
M experimental/SkV8Example/JsContext.cpp View 7 chunks +24 lines, -26 lines 0 comments Download
M experimental/SkV8Example/Path2D.cpp View 10 chunks +22 lines, -22 lines 0 comments Download
M experimental/SkV8Example/SkV8Example.h View 1 1 chunk +1 line, -1 line 0 comments Download
M experimental/SkV8Example/SkV8Example.cpp View 1 2 3 4 3 chunks +18 lines, -12 lines 0 comments Download
M gyp/v8.gyp View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jcgregorio
6 years, 2 months ago (2014-10-24 18:07:36 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-10-24 18:43:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673223002/80001
6 years, 2 months ago (2014-10-24 18:44:02 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 19:49:31 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as e22f45fd89ef70b2ba645c354e951365ab8540c7

Powered by Google App Engine
This is Rietveld 408576698