content/browser/accessibility/browser_accessibility_cocoa.mm - Issue 673213002: HTML article tag should have AXRoleDescription as 'article'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 673213002: HTML article tag should have AXRoleDescription as 'article' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_cocoa.mm

diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm

index aa11b5fdc330554c319f83482ef62c0fb06f073e..923d814dcc44c288b672915f3f212bba4e0ca575 100644

--- a/content/browser/accessibility/browser_accessibility_cocoa.mm

+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm

@@ -575,6 +575,10 @@ NSDictionary* attributeToMethodNameMap = nil;

}

switch([self internalRole]) {

+ case ui::AX_ROLE_ARTICLE:

+ return base::SysUTF16ToNSString(content_client->GetLocalizedString(

+ IDS_AX_ROLE_ARTICLE));

+ break;

case ui::AX_ROLE_BANNER:

return base::SysUTF16ToNSString(content_client->GetLocalizedString(

IDS_AX_ROLE_BANNER));

« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »