Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1140)

Side by Side Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 673213002: HTML article tag should have AXRoleDescription as 'article' (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <execinfo.h> 5 #include <execinfo.h>
6 6
7 #import "content/browser/accessibility/browser_accessibility_cocoa.h" 7 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
8 8
9 #include <map> 9 #include <map>
10 10
(...skipping 557 matching lines...) Expand 10 before | Expand all | Expand 10 after
568 if ((internalRole != ui::AX_ROLE_GROUP && 568 if ((internalRole != ui::AX_ROLE_GROUP &&
569 internalRole != ui::AX_ROLE_LIST_ITEM) || 569 internalRole != ui::AX_ROLE_LIST_ITEM) ||
570 internalRole == ui::AX_ROLE_TAB) { 570 internalRole == ui::AX_ROLE_TAB) {
571 // TODO(dtseng): This is not localized; see crbug/84814. 571 // TODO(dtseng): This is not localized; see crbug/84814.
572 return base::SysUTF8ToNSString(role); 572 return base::SysUTF8ToNSString(role);
573 } 573 }
574 } 574 }
575 } 575 }
576 576
577 switch([self internalRole]) { 577 switch([self internalRole]) {
578 case ui::AX_ROLE_ARTICLE:
579 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
580 IDS_AX_ROLE_ARTICLE));
581 break;
578 case ui::AX_ROLE_BANNER: 582 case ui::AX_ROLE_BANNER:
579 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 583 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
580 IDS_AX_ROLE_BANNER)); 584 IDS_AX_ROLE_BANNER));
581 break; 585 break;
582 case ui::AX_ROLE_FOOTER: 586 case ui::AX_ROLE_FOOTER:
583 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 587 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
584 IDS_AX_ROLE_FOOTER)); 588 IDS_AX_ROLE_FOOTER));
585 case ui::AX_ROLE_REGION: 589 case ui::AX_ROLE_REGION:
586 return base::SysUTF16ToNSString(content_client->GetLocalizedString( 590 return base::SysUTF16ToNSString(content_client->GetLocalizedString(
587 IDS_AX_ROLE_REGION)); 591 IDS_AX_ROLE_REGION));
(...skipping 865 matching lines...) Expand 10 before | Expand all | Expand 10 after
1453 return [super hash]; 1457 return [super hash];
1454 return browserAccessibility_->GetId(); 1458 return browserAccessibility_->GetId();
1455 } 1459 }
1456 1460
1457 - (BOOL)accessibilityShouldUseUniqueId { 1461 - (BOOL)accessibilityShouldUseUniqueId {
1458 return YES; 1462 return YES;
1459 } 1463 }
1460 1464
1461 @end 1465 @end
1462 1466
OLDNEW
« no previous file with comments | « content/app/strings/content_strings.grd ('k') | content/browser/accessibility/dump_accessibility_tree_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698