Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 673183002: Increase the default buffer size from 128 to 256 on Mac (Closed)

Created:
6 years, 2 months ago by no longer working on chromium
Modified:
6 years, 1 month ago
Reviewers:
DaleCurtis, *Raymond Toy
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Increase the default buffer size from 128 to 256 on Mac. This is to avoid glitches when webaudio and webrtc streams are used at the same time. TBR=rtoy@chromium.org BUG=423696 Committed: https://crrev.com/ca469461bbd554ecddc82ea91d2cef7f3df5502e Cr-Commit-Position: refs/heads/master@{#301367}

Patch Set 1 #

Patch Set 2 : updated the comment. #

Total comments: 3

Patch Set 3 : added a link to the webaudio buffer size issue. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -10 lines) Patch
M media/audio/mac/audio_manager_mac.h View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_manager_mac.cc View 1 2 3 5 chunks +18 lines, -9 lines 0 comments Download

Messages

Total messages: 23 (11 generated)
no longer working on chromium
https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_manager_mac.cc File media/audio/mac/audio_manager_mac.cc (right): https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_manager_mac.cc#newcode728 media/audio/mac/audio_manager_mac.cc:728: int buffer_size = is_input ? Dale, for the input ...
6 years, 2 months ago (2014-10-24 10:05:29 UTC) #2
DaleCurtis
+rtoy for lgtm since this will raise the minimum buffer size for WebAudio on OSX ...
6 years, 1 month ago (2014-10-24 17:04:43 UTC) #5
no longer working on chromium
Done, landing now. https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_manager_mac.cc File media/audio/mac/audio_manager_mac.cc (right): https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_manager_mac.cc#newcode727 media/audio/mac/audio_manager_mac.cc:727: // buffer size. On 2014/10/24 17:04:43, ...
6 years, 1 month ago (2014-10-27 10:58:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/40001
6 years, 1 month ago (2014-10-27 10:59:48 UTC) #9
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
6 years, 1 month ago (2014-10-27 10:59:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/40001
6 years, 1 month ago (2014-10-27 14:02:38 UTC) #13
commit-bot: I haz the power
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from ...
6 years, 1 month ago (2014-10-27 14:02:41 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/40001
6 years, 1 month ago (2014-10-27 14:03:26 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73908) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/28545)
6 years, 1 month ago (2014-10-27 14:23:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/60001
6 years, 1 month ago (2014-10-27 14:35:16 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-27 15:46:10 UTC) #22
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 15:46:52 UTC) #23
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ca469461bbd554ecddc82ea91d2cef7f3df5502e
Cr-Commit-Position: refs/heads/master@{#301367}

Powered by Google App Engine
This is Rietveld 408576698