|
|
Created:
6 years, 2 months ago by no longer working on chromium Modified:
6 years, 1 month ago CC:
chromium-reviews, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Project:
chromium Visibility:
Public. |
DescriptionIncrease the default buffer size from 128 to 256 on Mac.
This is to avoid glitches when webaudio and webrtc streams are used at the same time.
TBR=rtoy@chromium.org
BUG=423696
Committed: https://crrev.com/ca469461bbd554ecddc82ea91d2cef7f3df5502e
Cr-Commit-Position: refs/heads/master@{#301367}
Patch Set 1 #Patch Set 2 : updated the comment. #
Total comments: 3
Patch Set 3 : added a link to the webaudio buffer size issue. #Patch Set 4 : #
Messages
Total messages: 23 (11 generated)
xians@chromium.org changed reviewers: + dalecurtis@google.com
https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_ma... File media/audio/mac/audio_manager_mac.cc (right): https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_ma... media/audio/mac/audio_manager_mac.cc:728: int buffer_size = is_input ? Dale, for the input side, we still want 128 samples as the lowest buffer size, this is used by getUserMedia + AudioContext.createMediaStreamSource(). For the output side, this CL increase the buffer size from 128 to 256 when the sample rates are lower than 96K, to avoid glitches. Since most of the webrtc users use 44.1kHz or 48KHz, I don't remember we got audio issues when the sample rate is 96KHz, so I don't increase the buffer size for 96K. Let me know if you have different opinion. Thanks.
dalecurtis@chromium.org changed reviewers: + dalecurtis@chromium.org, rtoy@chromium.org
dalecurtis@chromium.org changed required reviewers: + rtoy@chromium.org
+rtoy for lgtm since this will raise the minimum buffer size for WebAudio on OSX to 256 (from 128). lgtm https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_ma... File media/audio/mac/audio_manager_mac.cc (right): https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_ma... media/audio/mac/audio_manager_mac.cc:727: // buffer size. Link to tracking bug?
dalecurtis@chromium.org changed reviewers: - dalecurtis@google.com
Done, landing now. https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_ma... File media/audio/mac/audio_manager_mac.cc (right): https://codereview.chromium.org/673183002/diff/20001/media/audio/mac/audio_ma... media/audio/mac/audio_manager_mac.cc:727: // buffer size. On 2014/10/24 17:04:43, DaleCurtis wrote: > Link to tracking bug? Done.
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/40001
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/40001
The CQ bit was unchecked by commit-bot@chromium.org
All required reviewers (with asterisk prefixes) have not yet approved this CL. No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73908) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
The CQ bit was checked by xians@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673183002/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/ca469461bbd554ecddc82ea91d2cef7f3df5502e Cr-Commit-Position: refs/heads/master@{#301367} |