Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 673143002: Unknown WebAXRole from Blink should be mapped to a valid chromium AX role. (Closed)

Created:
6 years, 1 month ago by dmazzoni
Modified:
6 years, 1 month ago
Reviewers:
aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Unknown WebAXRole from Blink should be mapped to a valid chromium AX role. If not, it leads to a crash later because we don't expect invalied AX roles in Chromium. We have to tolerate unknown AX roles from Blink because otherwise there's no way for us to introduce new roles to the Blink enum. BUG=426608 TBR=aboxhall Committed: https://crrev.com/6874f8183601e89123e52b636cf49777dc40d7f1 Cr-Commit-Position: refs/heads/master@{#301072}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M content/renderer/accessibility/blink_ax_enum_conversion.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/673143002/1
6 years, 1 month ago (2014-10-24 06:59:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-24 07:47:55 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-10-24 07:48:37 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6874f8183601e89123e52b636cf49777dc40d7f1
Cr-Commit-Position: refs/heads/master@{#301072}

Powered by Google App Engine
This is Rietveld 408576698