Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2411)

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 673143002: Unknown WebAXRole from Blink should be mapped to a valid chromium AX role. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/accessibility/blink_ax_enum_conversion.cc
diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc
index 8d8b3471260990b0c7d9374a2055e22545039110..a9e63476608e818fd96e006d27c72b57d13e0ee5 100644
--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc
+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc
@@ -333,7 +333,9 @@ ui::AXRole AXRoleFromBlink(blink::WebAXRole role) {
default:
// We can't add an assertion here, that prevents us
// from adding new role enums in Blink.
- return static_cast<ui::AXRole>(-1);
+ LOG(WARNING) << "Warning: Blink WebAXRole " << role
+ << " not handled by Chromium yet.";
+ return ui::AX_ROLE_UNKNOWN;
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698