Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 673033002: Remove WebThread (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Visibility:
Public.

Description

Remove WebThread We still have WebThread::Task, but WebThread is now gone. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/77594c54e178290c27611179b6d59126b4504afb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -649 lines) Patch
M sky/engine/bindings/core/v8/V8PerIsolateData.cpp View 2 chunks +3 lines, -6 lines 0 comments Download
D sky/engine/platform/heap/glue/MessageLoopInterruptor.h View 1 chunk +0 lines, -73 lines 0 comments Download
M sky/engine/public/platform/Platform.h View 2 chunks +0 lines, -8 lines 0 comments Download
M sky/engine/public/platform/WebThread.h View 1 chunk +0 lines, -30 lines 0 comments Download
M sky/engine/testing/platform/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 2 chunks +0 lines, -4 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 4 chunks +1 line, -26 lines 0 comments Download
D sky/engine/testing/platform/webthread_impl.h View 1 chunk +0 lines, -78 lines 0 comments Download
D sky/engine/testing/platform/webthread_impl.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M sky/engine/web/WebKit.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M sky/viewer/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 3 chunks +0 lines, -4 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 4 chunks +1 line, -26 lines 0 comments Download
D sky/viewer/platform/webthread_impl.h View 1 chunk +0 lines, -84 lines 0 comments Download
D sky/viewer/platform/webthread_impl.cc View 1 chunk +0 lines, -166 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-10-23 21:36:02 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-10-23 21:36:44 UTC) #2
abarth-chromium
6 years, 1 month ago (2014-10-23 21:37:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
77594c54e178290c27611179b6d59126b4504afb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698