Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Unified Diff: sky/engine/bindings/core/v8/V8PerIsolateData.cpp

Issue 673033002: Remove WebThread (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/platform/heap/glue/MessageLoopInterruptor.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/core/v8/V8PerIsolateData.cpp
diff --git a/sky/engine/bindings/core/v8/V8PerIsolateData.cpp b/sky/engine/bindings/core/v8/V8PerIsolateData.cpp
index c6af66d04db2efcb82e12d3231ef4877a9c77459..298fd854b4d0bee4c8152c08ac306f176b543f2a 100644
--- a/sky/engine/bindings/core/v8/V8PerIsolateData.cpp
+++ b/sky/engine/bindings/core/v8/V8PerIsolateData.cpp
@@ -77,12 +77,10 @@ V8PerIsolateData::V8PerIsolateData()
isolate()->Enter();
#if ENABLE(ASSERT)
// currentThread will always be non-null in production, but can be null in Chromium unit tests.
- if (blink::Platform::current()->currentThread())
- isolate()->AddCallCompletedCallback(&assertV8RecursionScope);
+ isolate()->AddCallCompletedCallback(&assertV8RecursionScope);
#endif
- if (isMainThread()) {
+ if (isMainThread())
mainThreadPerIsolateData = this;
- }
isolate()->SetUseCounterCallback(&useCounterCallback);
}
@@ -119,8 +117,7 @@ v8::Persistent<v8::Value>& V8PerIsolateData::ensureLiveRoot()
void V8PerIsolateData::dispose(v8::Isolate* isolate)
{
#if ENABLE(ASSERT)
- if (blink::Platform::current()->currentThread())
- isolate->RemoveCallCompletedCallback(&assertV8RecursionScope);
+ isolate->RemoveCallCompletedCallback(&assertV8RecursionScope);
#endif
void* data = isolate->GetData(gin::kEmbedderBlink);
// FIXME: Remove once all v8::Isolate::GetCurrent() calls are gone.
« no previous file with comments | « no previous file | sky/engine/platform/heap/glue/MessageLoopInterruptor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698