Issue 6730034: Remove all "net::" prefixes under net/url_request for code that's

Issue 6730034: Remove all "net::" prefixes under net/url_request for code that's (Closed)

Created:
9 years, 9 months ago by adamk

Modified:
9 years, 7 months ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Remove all "net::" prefixes under net/url_request for code that's already in the net namespace. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79340

Patch Set 2 : Copyright presubmit #

Total comments: 2

Patch Set 3 : Fixed indentation #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -403 lines)			Patch
M	net/url_request/https_prober.h	View		4 chunks	+12 lines, -12 lines	0 comments	Download
M	net/url_request/https_prober.cc	View	1	4 chunks	+11 lines, -11 lines	0 comments	Download
M	net/url_request/url_request.h	View		17 chunks	+32 lines, -32 lines	0 comments	Download
M	net/url_request/url_request.cc	View	1 2	21 chunks	+42 lines, -43 lines	0 comments	Download
M	net/url_request/url_request_context.h	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	net/url_request/url_request_error_job.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_filter.h	View	1	3 chunks	+10 lines, -10 lines	0 comments	Download
M	net/url_request/url_request_filter.cc	View	1 2	8 chunks	+13 lines, -14 lines	0 comments	Download
M	net/url_request/url_request_http_job.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_http_job.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/url_request/url_request_job.cc	View		15 chunks	+18 lines, -18 lines	0 comments	Download
M	net/url_request/url_request_job_manager.h	View	1	4 chunks	+14 lines, -14 lines	0 comments	Download
M	net/url_request/url_request_job_manager.cc	View	1	11 chunks	+26 lines, -26 lines	0 comments	Download
M	net/url_request/url_request_job_tracker.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_throttler_entry_interface.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_throttler_header_adapter.h	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/url_request/url_request_throttler_header_adapter.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/url_request/url_request_throttler_unittest.cc	View	1	9 chunks	+17 lines, -13 lines	0 comments	Download
M	net/url_request/url_request_unittest.cc	View		96 chunks	+160 lines, -156 lines	0 comments	Download
M	net/url_request/view_cache_helper.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	net/url_request/view_cache_helper.cc	View	1	7 chunks	+9 lines, -9 lines	0 comments	Download
M	net/url_request/view_cache_helper_unittest.cc	View		12 chunks	+26 lines, -22 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

adamk

This was just bugging me whenever I read URLRequest code, so I figured I'd fix ...

9 years, 9 months ago (2011-03-24 22:17:35 UTC) #2

willchan no longer on Chromium

LGTM http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request.cc File net/url_request/url_request.cc (right): http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request.cc#newcode647 net/url_request/url_request.cc:647: NetLog::SOURCE_URL_REQUEST); indentation is off http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request_filter.cc File net/url_request/url_request_filter.cc (right): ...

9 years, 9 months ago (2011-03-24 23:14:09 UTC) #4

adamk

Fixed and fixed. How would you feel about a similar CL for net/base? On Thu, ...

9 years, 9 months ago (2011-03-24 23:17:24 UTC) #5

willchan no longer on Chromium

9 years, 9 months ago (2011-03-24 23:18:20 UTC) #6

sounds good

On Thu, Mar 24, 2011 at 4:17 PM, Adam Klein <adamk@chromium.org> wrote:

> Fixed and fixed.  How would you feel about a similar CL for net/base?
>
>
> On Thu, Mar 24, 2011 at 4:14 PM, <willchan@chromium.org> wrote:
>
>> LGTM
>>
>>
>>
>>
http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request.cc
>> File net/url_request/url_request.cc (right):
>>
>>
>>
http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request....
>> net/url_request/url_request.cc:647: NetLog::SOURCE_URL_REQUEST);
>> indentation is off
>>
>>
>>
http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request_...
>> File net/url_request/url_request_filter.cc (right):
>>
>>
>>
http://codereview.chromium.org/6730034/diff/1023/net/url_request/url_request_...
>> net/url_request/url_request_filter.cc:37: &URLRequestFilter::Factory);
>> indentation
>>
>>
>> http://codereview.chromium.org/6730034/
>>
>
>

Expand Messages | Collapse Messages