Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 672733002: [ServiceWorkerCache] Don't handle response blobs if they don't exist (Closed)

Created:
6 years, 2 months ago by jkarlin
Modified:
6 years, 2 months ago
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCache] Don't handle response blobs if they don't exist Need to add some guards. Clearly the dispatcher needs to have tests which I hope to get to asap. BUG=426150 Committed: https://crrev.com/01ac3bd6ad9ad0c081efaade1d5aa257a36be272 Cr-Commit-Position: refs/heads/master@{#300817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M content/browser/service_worker/service_worker_cache_listener.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
jkarlin
falken@chromium.org: Please review changes in all michaeln@chromium.org: Please review changes in all Thanks!
6 years, 2 months ago (2014-10-22 19:49:07 UTC) #2
michaeln1
lgtm
6 years, 2 months ago (2014-10-22 20:01:20 UTC) #3
jkarlin
On 2014/10/22 20:01:20, michaeln1 wrote: > lgtm Thanks! But can you lgtm from your other ...
6 years, 2 months ago (2014-10-22 21:03:21 UTC) #4
michaeln
doh, lgtm 2
6 years, 2 months ago (2014-10-22 21:22:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672733002/1
6 years, 2 months ago (2014-10-22 21:32:30 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel/builds/5151)
6 years, 2 months ago (2014-10-23 00:02:27 UTC) #9
jsbell
On 2014/10/23 00:02:27, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 2 months ago (2014-10-23 00:13:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672733002/1
6 years, 2 months ago (2014-10-23 00:13:55 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 01:41:29 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 01:46:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/01ac3bd6ad9ad0c081efaade1d5aa257a36be272
Cr-Commit-Position: refs/heads/master@{#300817}

Powered by Google App Engine
This is Rietveld 408576698