Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Unified Diff: content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc

Issue 672733002: [ServiceWorkerCache] Don't handle response blobs if they don't exist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/service_worker/service_worker_cache_listener.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
diff --git a/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc b/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
index b483b7d8f39b939079761c5bf865ca36774a3dc1..2f6e1b2121b2c924ee5cd577e27b2008d88fbe68 100644
--- a/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
+++ b/content/renderer/service_worker/service_worker_cache_storage_dispatcher.cc
@@ -520,12 +520,13 @@ void ServiceWorkerCacheStorageDispatcher::PopulateWebResponseFromResponse(
base::ASCIIToUTF16(i.second));
}
- web_response->setBlob(blink::WebString::fromUTF8(response.blob_uuid),
- response.blob_size);
-
- // Let the host know that it can release its reference to the blob.
- script_context_->Send(new ServiceWorkerHostMsg_BlobDataHandled(
- script_context_->GetRoutingID(), response.blob_uuid));
+ if (!response.blob_uuid.empty()) {
+ web_response->setBlob(blink::WebString::fromUTF8(response.blob_uuid),
+ response.blob_size);
+ // Let the host know that it can release its reference to the blob.
+ script_context_->Send(new ServiceWorkerHostMsg_BlobDataHandled(
+ script_context_->GetRoutingID(), response.blob_uuid));
+ }
}
blink::WebVector<blink::WebServiceWorkerResponse>
« no previous file with comments | « content/browser/service_worker/service_worker_cache_listener.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698