Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 672593002: 2D canvas: fix shadow rendering with "copy" compositing mode. (Closed)

Created:
6 years, 2 months ago by dshwang
Modified:
6 years, 2 months ago
CC:
blink-reviews, aandrey+blink_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

2D canvas: fix shadow rendering with "copy" compositing mode. "copy" also needs temp layer, but we optimized it via clearing the canvas. It's why we missed handling "copy" when we fix the bug related to shadow with "source-in". This CL optimizes shadow with "copy" by not-drawing a shadow. TEST=layout test fast/canvas/canvas-composite-shadow.html BUG=417409 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -0 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-composite-shadow.html View 1 chunk +89 lines, -0 lines 0 comments Download
M Source/core/html/canvas/CanvasRenderingContext2D.cpp View 5 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dshwang
could you review?
6 years, 2 months ago (2014-10-22 13:52:47 UTC) #2
Justin Novosad
On 2014/10/22 13:52:47, dshwang wrote: > could you review? lgtm. This is a great test. ...
6 years, 2 months ago (2014-10-22 15:01:22 UTC) #3
dshwang
On 2014/10/22 15:01:22, junov wrote: > On 2014/10/22 13:52:47, dshwang wrote: > > could you ...
6 years, 2 months ago (2014-10-22 15:19:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672593002/1
6 years, 2 months ago (2014-10-22 15:20:14 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 15:25:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184190

Powered by Google App Engine
This is Rietveld 408576698