Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 672533002: Enable separatorWrap module in CheckStyle and fix all the issues. (Closed)

Created:
6 years, 2 months ago by aurimas (slooooooooow)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, zea+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, dmazzoni+watch_chromium.org, ben+mojo_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, aboxhall+watch_chromium.org, lcwu+watch_chromium.org, chromoting-reviews_chromium.org, jam, abarth-chromium, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, android-webview-reviews_chromium.org, yuzo+watch_chromium.org, klundberg+watch_chromium.org, maniscalco+watch_chromium.org, plundblad+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable separatorWrap module in CheckStyle and fix all the issues. BUG=318404 TBR=boliu@chromium.org,mef@chromium.org,zea@chromium.org,kollas@chromium.org Committed: https://crrev.com/7b38f8b35666252d764525802443bd62b23bad5e Cr-Commit-Position: refs/heads/master@{#300753}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Ted's nits #

Patch Set 3 : Undo mojo changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+246 lines, -236 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwSettingsTest.java View 25 chunks +116 lines, -116 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CookieManagerTest.java View 5 chunks +12 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 3 chunks +11 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/OAuth2TokenService.java View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsTest.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java View 1 chunk +4 lines, -4 lines 0 comments Download
M chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactory.java View 2 chunks +4 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/AccessibilityInjector.java View 4 chunks +18 lines, -18 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/accessibility/JellyBeanAccessibilityInjector.java View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/Chromoting.java View 1 2 chunks +4 lines, -4 lines 0 comments Download
M remoting/android/java/src/org/chromium/chromoting/jni/JniInterface.java View 1 chunk +8 lines, -8 lines 0 comments Download
M sync/android/java/src/org/chromium/sync/notifier/SyncStatusHelper.java View 2 chunks +6 lines, -6 lines 0 comments Download
M sync/android/javatests/src/org/chromium/sync/notifier/signin/SyncStatusHelperTest.java View 1 chunk +6 lines, -6 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/AccountHolder.java View 3 chunks +6 lines, -6 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 7 chunks +23 lines, -23 lines 0 comments Download
M tools/android/checkstyle/chromium-style-5.0.xml View 1 chunk +10 lines, -0 lines 0 comments Download
M tools/android/memconsumer/java/src/org/chromium/memconsumer/ResidentService.java View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/base/DeviceFormFactor.java View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
aurimas (slooooooooow)
Hey Ted, Please take a look at this change. Thanks, Aurimas
6 years, 2 months ago (2014-10-22 01:47:17 UTC) #2
Ted C
lgtm https://chromiumcodereview.appspot.com/672533002/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java File remoting/android/java/src/org/chromium/chromoting/Chromoting.java (right): https://chromiumcodereview.appspot.com/672533002/diff/1/remoting/android/java/src/org/chromium/chromoting/Chromoting.java#newcode359 remoting/android/java/src/org/chromium/chromoting/Chromoting.java:359: .putString("account_type", mAccount.type).apply(); -4 indent here
6 years, 2 months ago (2014-10-22 17:18:05 UTC) #3
Lambros
remoting/ lgtm
6 years, 2 months ago (2014-10-22 17:28:40 UTC) #5
aurimas (slooooooooow)
TBR the following people: boliu@chromium.org: Please review changes in android_webview/ mef@chromium.org: Please review changes in ...
6 years, 2 months ago (2014-10-22 18:22:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672533002/40001
6 years, 2 months ago (2014-10-22 18:25:34 UTC) #9
mef
On 2014/10/22 18:25:34, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 2 months ago (2014-10-22 20:17:47 UTC) #11
boliu
On 2014/10/22 18:22:09, aurimas wrote: > TBR the following people: > > mailto:boliu@chromium.org: Please review ...
6 years, 2 months ago (2014-10-22 20:29:24 UTC) #12
gunsch
chromecast/ lgtm
6 years, 2 months ago (2014-10-22 20:33:21 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 2 months ago (2014-10-22 20:59:50 UTC) #14
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 21:01:19 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7b38f8b35666252d764525802443bd62b23bad5e
Cr-Commit-Position: refs/heads/master@{#300753}

Powered by Google App Engine
This is Rietveld 408576698