chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java - Issue 672533002: Enable separatorWrap module in CheckStyle and fix all the issues.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

Issue 672533002: Enable separatorWrap module in CheckStyle and fix all the issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Undo mojo changes Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/dom_distiller/DistilledPagePrefsTest.java ('k') | chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastCrashHandler.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

index 63e65b7bf8165e92eb2fe1ff8e176fd6b3426725..50dc4585c027245a5fa4a5322113b8ed5d77b7c6 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/omnibox/SuggestionPopup.java

@@ -104,10 +104,10 @@ public class SuggestionPopup implements OnSuggestionsReceivedListener, TextWatch

private int getSuggestionPopupHeight() {

Rect appRect = new Rect();

- ((ChromeShellActivity) mContext).getWindow().getDecorView().

- getWindowVisibleDisplayFrame(appRect);

- int dropDownItemHeight = mContext.getResources().

- getDimensionPixelSize(R.dimen.dropdown_item_height);

+ ((ChromeShellActivity) mContext).getWindow().getDecorView()

+ .getWindowVisibleDisplayFrame(appRect);

+ int dropDownItemHeight = mContext.getResources()

+ .getDimensionPixelSize(R.dimen.dropdown_item_height);

// Applying margin height equal to |dropDownItemHeight| if constrained by app rect.

int popupHeight = appRect.height() - dropDownItemHeight;

if (mSuggestionsPopup != null) {