Issue 672473002: Widen the set of nested rects that can be drawn natively on the GPU

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 672473002: Widen the set of nested rects that can be drawn natively on the GPU (Closed)

Created:
6 years, 2 months ago by robertphillips

Modified:
6 years, 2 months ago

Reviewers:
jvanverth1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Widen the set of nested rects that can be drawn natively on the GPU GrAARectRenderer::fillAANestedRects only handles thin stroked rects correctly if the margins are all the same. It is also correct if all the margins are >= 1.0f. This CL allows such cases to use the fillAANestedRects fast path. This seems to halve the gpu rendering time of the picture in bug crbug.com/425427. Committed: https://skia.googlesource.com/skia/+/183e98559c2edf6b262fa6c6fff7f3013eb42f5a

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
	M	src/gpu/GrAARectRenderer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	src/gpu/GrContext.cpp	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/672473002/1

6 years, 2 months ago (2014-10-21 18:19:05 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-21 18:25:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 183e98559c2edf6b262fa6c6fff7f3013eb42f5a

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages