Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(994)

Issue 6724010: Pepper/Flapper: Add IsFormatAvailable() to PPB_Flash_Clipboard. (Closed)

Created:
9 years, 9 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
vtl, brettw
CC:
chromium-reviews, pam+watch_chromium.org, piman+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Pepper/Flapper: Add IsFormatAvailable() to PPB_Flash_Clipboard. This requires a WebKit change (see https://bugs.webkit.org/show_bug.cgi?id=56868). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79289

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -5 lines) Patch
M ppapi/c/private/ppb_flash_clipboard.h View 3 chunks +14 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_messages.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_clipboard_proxy.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_clipboard_proxy.cc View 4 chunks +40 lines, -0 lines 0 comments Download
M webkit/glue/webclipboard_impl.cc View 2 chunks +8 lines, -3 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_clipboard_impl.cc View 3 chunks +35 lines, -0 lines 0 comments Download
M webkit/tools/test_shell/mock_webclipboard_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
9 years, 9 months ago (2011-03-22 22:24:19 UTC) #1
brettw
Isn't there a race condition here? If Flash is running asynchronously, couldn't the contents and ...
9 years, 9 months ago (2011-03-23 02:18:12 UTC) #2
vtl
Such functions always have a race condition (even without async -- since some other program ...
9 years, 9 months ago (2011-03-23 03:41:35 UTC) #3
brettw
9 years, 9 months ago (2011-03-23 16:00:04 UTC) #4
Okay, I was worried that the use case was more like
  if (isHTMLAvailable())
    getHTMLClipboardData();
but your use case sounds correct.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698