Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issue 672393003: Subzero: Minor refactoring/additions in preparation for phi edge splitting. (Closed)

Created:
6 years, 2 months ago by Jim Stichnoth
Modified:
6 years, 2 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Visibility:
Public.

Description

Subzero: Minor refactoring/additions in preparation for phi edge splitting. The only functional change (though not actually visible at this point) is that redundant assignment elimination is moved into a separate pass. BUG= none R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=98712a39588f258eba8e6448a53a182de4fd1c3c

Patch Set 1 #

Patch Set 2 : Add a comment #

Total comments: 2

Patch Set 3 : Remove deprecated advanceBackward method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
M src/IceCfg.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/IceCfg.cpp View 1 chunk +13 lines, -0 lines 0 comments Download
M src/IceCfgNode.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceCfgNode.cpp View 1 2 1 chunk +0 lines, -4 lines 0 comments Download
M src/IceClFlags.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceInst.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/IceInstX8632.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/IceTargetLowering.h View 1 2 4 chunks +6 lines, -4 lines 0 comments Download
M src/IceTargetLowering.cpp View 1 2 2 chunks +3 lines, -10 lines 0 comments Download
M src/IceTargetLoweringX8632.h View 1 chunk +1 line, -1 line 0 comments Download
M src/IceTargetLoweringX8632.cpp View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jim Stichnoth
6 years, 2 months ago (2014-10-24 17:28:50 UTC) #2
jvoung (off chromium)
otherwise LGTM https://codereview.chromium.org/672393003/diff/20001/src/IceTargetLowering.h File src/IceTargetLowering.h (right): https://codereview.chromium.org/672393003/diff/20001/src/IceTargetLowering.h#newcode93 src/IceTargetLowering.h:93: void advanceBackward(InstList::iterator &I) const; Can this be ...
6 years, 2 months ago (2014-10-24 17:50:40 UTC) #3
Jim Stichnoth
https://codereview.chromium.org/672393003/diff/20001/src/IceTargetLowering.h File src/IceTargetLowering.h (right): https://codereview.chromium.org/672393003/diff/20001/src/IceTargetLowering.h#newcode93 src/IceTargetLowering.h:93: void advanceBackward(InstList::iterator &I) const; On 2014/10/24 17:50:40, jvoung wrote: ...
6 years, 2 months ago (2014-10-24 17:58:53 UTC) #4
Jim Stichnoth
6 years, 2 months ago (2014-10-24 17:59:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
98712a39588f258eba8e6448a53a182de4fd1c3c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698