src/IceInstX8632.h - Issue 672393003: Subzero: Minor refactoring/additions in preparation for phi edge splitting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceInstX8632.h

Issue 672393003: Subzero: Minor refactoring/additions in preparation for phi edge splitting. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Remove deprecated advanceBackward method Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceInstX8632.h

diff --git a/src/IceInstX8632.h b/src/IceInstX8632.h

index 81d3fd8c973dea7344b4f020d41de20cf96d708b..177843705355b9660a574fb233a0255d22929705 100644

--- a/src/IceInstX8632.h

+++ b/src/IceInstX8632.h

@@ -342,6 +342,7 @@ public:

// Create a conditional branch to a node.

static InstX8632Br *create(Cfg *Func, CfgNode *TargetTrue,

CfgNode *TargetFalse, CondX86::BrCond Condition) {

+ assert(Condition != CondX86::Br_None);

const InstX8632Label *NoLabel = NULL;

return new (Func->allocate<InstX8632Br>())

InstX8632Br(Func, TargetTrue, TargetFalse, NoLabel, Condition);

@@ -358,6 +359,7 @@ public:

// used for switch lowering.

static InstX8632Br *create(Cfg *Func, CfgNode *Target,

CondX86::BrCond Condition) {

+ assert(Condition != CondX86::Br_None);

const CfgNode *NoUncondTarget = NULL;

const InstX8632Label *NoLabel = NULL;

return new (Func->allocate<InstX8632Br>())

« no previous file with comments | « src/IceInst.h ('k') | src/IceTargetLowering.h » ('j') | no next file with comments »