Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp - Issue 672383003: [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

Issue 672383003: [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: geofencing/apis_not_implemented.html Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html ('K') | « Source/modules/serviceworkers/ServiceWorkerContainer.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

diff --git a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

index 04f0433e8f460e28853f1c22e537e34a4b78bfb9..90e63eb0afac98e94739ec1c65c24a196e104d48 100644

--- a/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

+++ b/Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

@@ -320,11 +320,11 @@ TEST_F(ServiceWorkerContainerTest, RegisterUnregister_NonHttpsSecureOriginDelega

ScriptState::Scope scriptScope(scriptState());

RegistrationOptions options;

options.setScope("y/");

- container->registerServiceWorker(scriptState(), "/z/worker.js", options);

+ container->registerServiceWorker(scriptState(), "/x/y/worker.js", options);

EXPECT_EQ(1ul, stubProvider.registerCallCount());

EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/")), stubProvider.registerScope());

- EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/z/worker.js")), stubProvider.registerScriptURL());

+ EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/worker.js")), stubProvider.registerScriptURL());

}

container->willBeDetachedFromFrame();