[ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory.

Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/serviceworkers/ServiceWorkerContainer.h"
 
 #include "bindings/core/v8/Dictionary.h"
 #include "bindings/core/v8/ScriptFunction.h"
 #include "bindings/core/v8/ScriptPromise.h"
@@ skipping 208 matching lines @@
         ExpectDOMException("SecurityError", "The origin of the script must match the current origin."));
 }
 
 TEST_F(ServiceWorkerContainerTest, Register_CrossOriginScopeIsRejected)
 {
     setPageURL("https://www.example.com");
     testRegisterRejected(
         "https://www.example.com",
         "wss://www.example.com/", // Differs by protocol
         ExpectDOMException("SecurityError", "The scope must match the current origin."));
 }

[falken, 2014/10/24 06:50:44]

can you add a test here for Register failing due to the path restriction?
(it'll be in addition to the end-to-end layout tests)

[horo, 2014/10/24 07:21:43]

Done.

 
 TEST_F(ServiceWorkerContainerTest, GetRegistration_NonSecureOriginIsRejected)
 {
     setPageURL("http://www.example.com/");
     testGetRegistrationRejected(
         "http://www.example.com/",
         ExpectDOMException("NotSupportedError", "Only secure origins are allowed. http://goo.gl/lq4gCo"));
 }
 
 TEST_F(ServiceWorkerContainerTest, GetRegistration_CrossOriginURLIsRejected)
@@ skipping 73 matching lines @@
     StubWebServiceWorkerProvider stubProvider;
     provide(stubProvider.provider());
 
     ServiceWorkerContainer* container = ServiceWorkerContainer::create(executionContext());
 
     // register
     {
         ScriptState::Scope scriptScope(scriptState());
         RegistrationOptions options;
         options.setScope("y/");
-        container->registerServiceWorker(scriptState(), "/z/worker.js", options);
+        container->registerServiceWorker(scriptState(), "/x/y/worker.js", options);
 
         EXPECT_EQ(1ul, stubProvider.registerCallCount());
         EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/")), stubProvider.registerScope());
-        EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/z/worker.js")), stubProvider.registerScriptURL());
+        EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/y/worker.js")), stubProvider.registerScriptURL());
     }
 
     container->willBeDetachedFromFrame();
 }
 
 TEST_F(ServiceWorkerContainerTest, GetRegistration_OmittedDocumentURLDefaultsToPageURL)
 {
     setPageURL("http://localhost/x/index.html");
 
     StubWebServiceWorkerProvider stubProvider;
     provide(stubProvider.provider());
 
     ServiceWorkerContainer* container = ServiceWorkerContainer::create(executionContext());
 
     {
         ScriptState::Scope scriptScope(scriptState());
         container->getRegistration(scriptState(), "");
         EXPECT_EQ(1ul, stubProvider.getRegistrationCallCount());
         EXPECT_EQ(WebURL(KURL(KURL(), "http://localhost/x/index.html")), stubProvider.getRegistrationURL());
     }
 
     container->willBeDetachedFromFrame();
 }
 
 } // namespace
 } // namespace blink