LayoutTests/http/tests/serviceworker/resources/test-helpers.js - Issue 672383003: [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/http/tests/serviceworker/resources/test-helpers.js

Issue 672383003: [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: geofencing/apis_not_implemented.html Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html ('K') | « LayoutTests/http/tests/serviceworker/registration-service-worker-attributes.html ('k') | LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html » ('j') | Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/http/tests/serviceworker/resources/test-helpers.js

diff --git a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

index bce1613150332dc92f7e40991d31329740e109e4..4889f547ffc361c79ed928d8663a3dbcc4f9d3fb 100644

--- a/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

+++ b/LayoutTests/http/tests/serviceworker/resources/test-helpers.js

@@ -199,9 +199,9 @@ function wait_for_activated(test, registration) {

};

function service_worker_test(url, description) {

- var scope = window.location.origin + '/service-worker-scope' +

+ var scope = new URL('./', new URL(url, window.location)) +

+ 'resources/service-worker-scope' +

window.location.pathname;

var test = async_test(description);

var registration;

service_worker_unregister_and_register(test, url, scope)