Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 672353003: Revert of [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. (Closed)

Created:
6 years, 2 months ago by Peter Beverloo
Modified:
6 years, 2 months ago
Reviewers:
falken, horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Revert of [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. (patchset #4 id:70001 of https://codereview.chromium.org/672383003/) Reason for revert: This patch seems to have broken the following two browser_tests on all platforms, as can be seen on the non-layout bots on the Blink waterfall. We won't be able to roll Blink in Chromium until this is resolved. PushMessagingBrowserTest.RegisterFailureNoPermission PushMessagingBrowserTest.RegisterSuccess Example output: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/4400/steps/browser_tests/logs/RegisterSuccess [INFO:CONSOLE(7)] "SecurityError - The scope must be under the directory of the script URL.", source: https://127.0.0.1:39935/files/push_messaging/test.html (7) ../../chrome/browser/services/gcm/push_messaging_browsertest.cc:142: Failure Value of: register_worker_result Actual: "SecurityError - The scope must be under the directory of the script URL." Expected: "ok" Original issue's description: > [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory. > > As per discussion on https://github.com/slightlyoff/ServiceWorker/issues/468 > > BUG=423983 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184336 TBR=falken@chromium.org,horo@chromium.org NOTREECHECKS=true NOTRY=true BUG=423983 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184364

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -117 lines) Patch
M LayoutTests/http/tests/geofencing/apis_not_implemented.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-absolute-url.html View 1 chunk +1 line, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-default.html View 1 chunk +3 lines, -9 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/ServiceWorkerGlobalScope/scope-relative-path.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/force-refresh-registration.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/registration-stress.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/chromium/service-worker-gc.html View 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/extendable-event-waituntil.html View 6 chunks +6 lines, -6 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/getregistration.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/interfaces.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/multiple-register.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/register-same-scope-different-script-url.html View 5 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration.html View 4 chunks +8 lines, -45 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-end-to-end.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-events.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-on-insecure-origin.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/registration-service-worker-attributes.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/test-helpers.js View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/serviceworkerobject-scripturl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/state.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/uncontrolled-page.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-controller.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/http/tests/serviceworker/unregister-then-register-new-script.html View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainer.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerContainerTest.cpp View 2 chunks +2 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Beverloo
Created Revert of [ServiceWorker] Don't allow registration of the ServiceWorker scope outside the script directory.
6 years, 2 months ago (2014-10-24 15:32:36 UTC) #1
horo
6 years, 1 month ago (2014-10-27 05:53:39 UTC) #2
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/653333006/ by horo@chromium.org.

The reason for reverting is: Fixed the test failure by changing the scope in
chrome/test/data/push_messaging/test.html.

https://codereview.chromium.org/644763005/
.

Powered by Google App Engine
This is Rietveld 408576698