Source/core/html/FormAssociatedElement.h - Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/FormAssociatedElement.h

Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add layout tests to catch the problem Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/form-pseudo-valid-style-expected.txt ('k') | Source/core/html/FormAssociatedElement.cpp » ('j') | Source/core/html/HTMLFormControlElement.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/FormAssociatedElement.h

diff --git a/Source/core/html/FormAssociatedElement.h b/Source/core/html/FormAssociatedElement.h

index 0946b78c4351a83f75514ef2eafb72aab82935b1..62c10447b94f71d1d6bfa96bbaa990b09817ff70 100644

--- a/Source/core/html/FormAssociatedElement.h

+++ b/Source/core/html/FormAssociatedElement.h

@@ -110,7 +110,7 @@ protected:

// derived from this one, you will need to add a call to setForm(0) to the

// destructor of that class.

virtual void willChangeForm();

- virtual void didChangeForm();

+ virtual void didChangeForm(HTMLFormElement* oldForm);

String customValidationMessage() const;