Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: Source/core/html/FormAssociatedElement.h

Issue 672163002: Fix bug where form/fieldset :valid/:invalid won't be recalculated upon control's willValidate change Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add layout tests to catch the problem Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 // FIXME: Remove usage of setForm. resetFormOwner should be enough, and 103 // FIXME: Remove usage of setForm. resetFormOwner should be enough, and
104 // setForm is confusing. 104 // setForm is confusing.
105 void setForm(HTMLFormElement*); 105 void setForm(HTMLFormElement*);
106 void associateByParser(HTMLFormElement*); 106 void associateByParser(HTMLFormElement*);
107 void formAttributeChanged(); 107 void formAttributeChanged();
108 108
109 // If you add an override of willChangeForm() or didChangeForm() to a class 109 // If you add an override of willChangeForm() or didChangeForm() to a class
110 // derived from this one, you will need to add a call to setForm(0) to the 110 // derived from this one, you will need to add a call to setForm(0) to the
111 // destructor of that class. 111 // destructor of that class.
112 virtual void willChangeForm(); 112 virtual void willChangeForm();
113 virtual void didChangeForm(); 113 virtual void didChangeForm(HTMLFormElement* oldForm);
114 114
115 String customValidationMessage() const; 115 String customValidationMessage() const;
116 116
117 private: 117 private:
118 #if !ENABLE(OILPAN) 118 #if !ENABLE(OILPAN)
119 virtual void refFormAssociatedElement() = 0; 119 virtual void refFormAssociatedElement() = 0;
120 virtual void derefFormAssociatedElement() = 0; 120 virtual void derefFormAssociatedElement() = 0;
121 #endif 121 #endif
122 122
123 void setFormAttributeTargetObserver(PassOwnPtrWillBeRawPtr<FormAttributeTarg etObserver>); 123 void setFormAttributeTargetObserver(PassOwnPtrWillBeRawPtr<FormAttributeTarg etObserver>);
(...skipping 15 matching lines...) Expand all
139 }; 139 };
140 140
141 HTMLElement* toHTMLElement(FormAssociatedElement*); 141 HTMLElement* toHTMLElement(FormAssociatedElement*);
142 HTMLElement& toHTMLElement(FormAssociatedElement&); 142 HTMLElement& toHTMLElement(FormAssociatedElement&);
143 const HTMLElement* toHTMLElement(const FormAssociatedElement*); 143 const HTMLElement* toHTMLElement(const FormAssociatedElement*);
144 const HTMLElement& toHTMLElement(const FormAssociatedElement&); 144 const HTMLElement& toHTMLElement(const FormAssociatedElement&);
145 145
146 } // namespace 146 } // namespace
147 147
148 #endif // FormAssociatedElement_h 148 #endif // FormAssociatedElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698