Refactoring of SessionService to get componentized.

chrome/browser/sessions/session_types.h

Index: chrome/browser/sessions/session_types.h
diff --git a/chrome/browser/sessions/session_types.h b/chrome/browser/sessions/session_types.h
index 35b4d29bae78060651e76b8044c5596f7692b997..9069cd10a0b1dff4e157934f16c77e0b6062b9a2 100644
--- a/chrome/browser/sessions/session_types.h
+++ b/chrome/browser/sessions/session_types.h
@@ -109,6 +109,12 @@ struct SessionWindow {
   SessionWindow();
   ~SessionWindow();
 
+  // Possible window types which can be stored here.
+  enum WindowType {
+    TYPE_TABBED = 0,
+    TYPE_POPUP = 1
+  };
+
   // Convert this object into its sync protocol buffer equivalent. Note that
   // not all fields are synced here, because they don't all make sense or
   // translate when restoring a SessionWindow on another device.
@@ -129,10 +135,11 @@ struct SessionWindow {
   // tabs.
   int selected_tab_index;
 
-  // Type of the browser. Currently we only store browsers of type
-  // TYPE_TABBED and TYPE_POPUP.
-  // This would be Browser::Type, but that would cause a circular dependency.

[Mr4D (OOO till 08-26), 2014/10/23 20:09:11]

Converted this into WindowType - decoupling from Browser specific code and
opening it for other types (required by athena). At the same time we are getting
rid of the untyped variable which cost me some grief to fiddle out.

-  int type;
+  // Type of the window. Note: This type is used to determine if the window gets
+  // saved or not.
+  // This would be SessionCommands::WindowType, but as long as this does not
+  // reside in a component, we keep it untyped.
+  WindowType type;
 
   // If true, the window is constrained.
   //