Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: chrome/browser/extensions/api/sessions/sessions_api.cc

Issue 672083002: Refactoring of SessionService to get componentized. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/sessions/sessions_api.cc
diff --git a/chrome/browser/extensions/api/sessions/sessions_api.cc b/chrome/browser/extensions/api/sessions/sessions_api.cc
index f8dc1ff8eced06a71be2d9f7e2855eabf901bab8..d72c6b9fbe69c6bbdcdc5c3a32d04049264084db 100644
--- a/chrome/browser/extensions/api/sessions/sessions_api.cc
+++ b/chrome/browser/extensions/api/sessions/sessions_api.cc
@@ -285,10 +285,10 @@ scoped_ptr<windows::Window> SessionsGetDevicesFunction::CreateWindowModel(
windows::Window::Type type = windows::Window::TYPE_NONE;
switch (window.type) {
- case Browser::TYPE_TABBED:
+ case SessionWindow::TYPE_TABBED: // TODO(skuhne) Check Browser::TYPE_TABBED
Mr4D (OOO till 08-26) 2014/10/23 20:09:10 I did go over all uses of WindowSession::type (whi
type = windows::Window::TYPE_NORMAL;
break;
- case Browser::TYPE_POPUP:
+ case SessionWindow::TYPE_POPUP: // TODO(skuhne): Check Browser::TYPE_POPUP:
type = windows::Window::TYPE_POPUP;
break;
}
« no previous file with comments | « no previous file | chrome/browser/sessions/base_session_service.h » ('j') | chrome/browser/sessions/session_types.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698