Add update url controlled extension management settings

Add update url controlled extension management settings

This CL adds per-update-url configurations to extension management policies. To address the problem that extension id and update URL in its manifest is not directly related, conflicting resolving behavior is define and implemented in a per-field terms for IndividualSettings in ExtensionManagement class.

BUG=177351
Committed: https://crrev.com/685ade8a3f43717cb7f5b257324466abba3c34b5
Cr-Commit-Position: refs/heads/master@{#302999}

[binjin, 2014-11-03 20:55:50]

binjin@chromium.org changed reviewers:
+ joaodasilva@chromium.org

[binjin, 2014-11-03 21:00:32]

Joao,

Could you have a look at this CL?

Some refactoring (eg. removing ReadByID) is made to simplify code, sorry for the
back and forth.

Thanks,
Bin

[Joao da Silva, 2014-11-04 14:06:10]

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_management.cc (right):

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:27: #include
"extensions/common/manifest.h"
Already in the header

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:188: APIPermissionSet unioned;
Rename this variable to |merged|

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:364:
internal::IndividualSettings* by_id = AccessByUpdateUrl(update_url);
Rename |by_id| here to |by_update_url|

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:367:
settings_by_id_.erase(update_url);
settings_by_update_url_

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_management_internal.h (right):

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_internal.h:59: // for
SCOPE_INDIVIDUAL and SCOPED_UPDATE_URL.
SCOPE_UPDATE_URL

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_management_unittest.cc (right):

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_unittest.cc:161: protected:
Why are some of the helper methods public and others protected?

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_unittest.cc:455:
TEST_F(ExtensionManagementServiceTest, InstallationModeConflictionHandling) {
InstallationModeConflicHandling

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_unittest.cc:470:
TEST_F(ExtensionManagementServiceTest, BlockedPermissionsConflictionHandling) {
BlockedPermissionsConflictHandling

[binjin, 2014-11-05 12:52:43]

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_management.cc (right):

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:27: #include
"extensions/common/manifest.h"
On 2014/11/04 14:06:09, Joao da Silva wrote:
> Already in the header

Done.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:188: APIPermissionSet unioned;
On 2014/11/04 14:06:09, Joao da Silva wrote:
> Rename this variable to |merged|

Done.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:364:
internal::IndividualSettings* by_id = AccessByUpdateUrl(update_url);
On 2014/11/04 14:06:09, Joao da Silva wrote:
> Rename |by_id| here to |by_update_url|

Done.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management.cc:367:
settings_by_id_.erase(update_url);
On 2014/11/04 14:06:09, Joao da Silva wrote:
> settings_by_update_url_

Done.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_management_internal.h (right):

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_internal.h:59: // for
SCOPE_INDIVIDUAL and SCOPED_UPDATE_URL.
On 2014/11/04 14:06:09, Joao da Silva wrote:
> SCOPE_UPDATE_URL

Done.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
File chrome/browser/extensions/extension_management_unittest.cc (right):

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_unittest.cc:161: protected:
On 2014/11/04 14:06:09, Joao da Silva wrote:
> Why are some of the helper methods public and others protected?

Done. Moving helper functions to public and internal one to private instead.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_unittest.cc:455:
TEST_F(ExtensionManagementServiceTest, InstallationModeConflictionHandling) {
On 2014/11/04 14:06:09, Joao da Silva wrote:
> InstallationModeConflicHandling

Done.

https://codereview.chromium.org/671943003/diff/60001/chrome/browser/extension...
chrome/browser/extensions/extension_management_unittest.cc:470:
TEST_F(ExtensionManagementServiceTest, BlockedPermissionsConflictionHandling) {
On 2014/11/04 14:06:10, Joao da Silva wrote:
> BlockedPermissionsConflictHandling

Done.

[Joao da Silva, 2014-11-05 13:19:16]

lgtm

[binjin, 2014-11-05 13:30:05]

binjin@chromium.org changed reviewers:
+ finnur@chromium.org

[binjin, 2014-11-05 13:30:05]

Finnur. Could you please do an owner review for this CL?

Thanks!

[Finnur, 2014-11-06 02:35:19]

Rubberstamp LGTM

[binjin, 2014-11-06 09:09:06]

The CQ bit was checked by binjin@chromium.org

[commit-bot: I haz the power, 2014-11-06 09:10:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/671943003/80001

[commit-bot: I haz the power, 2014-11-06 09:54:04]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-11-06 09:54:45]

Patchset 5 (id:??) landed as
https://crrev.com/685ade8a3f43717cb7f5b257324466abba3c34b5
Cr-Commit-Position: refs/heads/master@{#302999}