chrome/browser/extensions/extension_service.cc - Issue 671943003: Add update url controlled extension management settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 671943003: Add update url controlled extension management settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@ext-5

Patch Set: fixes addressing #3 Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_management_unittest.cc ('k') | chrome/browser/extensions/permissions_based_management_policy_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_service.cc

diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc

index 76ac9a2105c1d6f7e689a716ddfb33236fba9e0f..d8e601beb50ac115f6528daf73bf231b02b4ae96 100644

--- a/chrome/browser/extensions/extension_service.cc

+++ b/chrome/browser/extensions/extension_service.cc

@@ -1718,11 +1718,11 @@ void ExtensionService::OnExtensionManagementSettingsChanged() {

registry_->GenerateInstalledExtensionsSet());

for (const auto& extension : *all_extensions.get()) {

if (!settings->IsPermissionSetAllowed(

- extension->id(),

+ extension.get(),

extension->permissions_data()->active_permissions())) {

extensions::PermissionsUpdater(profile()).RemovePermissions(

extension.get(),

- settings->GetBlockedPermissions(extension->id()).get());

+ settings->GetBlockedPermissions(extension.get()).get());

}