chrome/browser/extensions/api/extension_action/browser_action_apitest.cc - Issue 671763002: Extract ProcessManager from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

Issue 671763002: Extract ProcessManager from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/developer_private/developer_private_api.cc ('k') | chrome/browser/extensions/api/management/management_api_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

diff --git a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

index ed52900c87028aab5a89fefe8955388db0f32521..3b034ccc5d13aed4bc57d30de0646b5afbbbd997 100644

--- a/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

+++ b/chrome/browser/extensions/api/extension_action/browser_action_apitest.cc

@@ -9,7 +9,6 @@

#include "chrome/browser/extensions/extension_action_icon_factory.h"

#include "chrome/browser/extensions/extension_action_manager.h"

#include "chrome/browser/extensions/extension_apitest.h"

-#include "chrome/browser/extensions/extension_service.h"

#include "chrome/browser/extensions/extension_tab_util.h"

#include "chrome/browser/extensions/extension_toolbar_model.h"

#include "chrome/browser/extensions/extension_util.h"

@@ -26,6 +25,7 @@

#include "extensions/browser/extension_registry.h"

#include "extensions/browser/extension_system.h"

#include "extensions/browser/notification_types.h"

+#include "extensions/browser/process_manager.h"

#include "extensions/browser/test_extension_registry_observer.h"

#include "extensions/common/feature_switch.h"

#include "extensions/test/result_catcher.h"

@@ -542,7 +542,7 @@ IN_PROC_BROWSER_TEST_F(BrowserActionApiTest, DISABLED_CloseBackgroundPage) {

// There is a background page and a browser action with no badge text.

extensions::ProcessManager* manager =

- extensions::ExtensionSystem::Get(browser()->profile())->process_manager();

+ extensions::ProcessManager::Get(browser()->profile());

ASSERT_TRUE(manager->GetBackgroundHostForExtension(extension->id()));

ExtensionAction* action = GetBrowserAction(*extension);

ASSERT_EQ("", action->GetBadgeText(ExtensionAction::kDefaultTabId));