chrome/browser/extensions/api/developer_private/developer_private_api.cc - Issue 671763002: Extract ProcessManager from ExtensionSystem.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/developer_private/developer_private_api.cc

Issue 671763002: Extract ProcessManager from ExtensionSystem. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebased. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/debugger/debugger_api.cc ('k') | chrome/browser/extensions/api/extension_action/browser_action_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/developer_private/developer_private_api.cc

diff --git a/chrome/browser/extensions/api/developer_private/developer_private_api.cc b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

index de6e61bc13ce85d71d8c174e2554d4cc7216075a..1f95298a4f9b71176d7b644ae7b93d959d87b5e2 100644

--- a/chrome/browser/extensions/api/developer_private/developer_private_api.cc

+++ b/chrome/browser/extensions/api/developer_private/developer_private_api.cc

@@ -563,8 +563,7 @@ ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::

bool extension_is_enabled) {

ItemInspectViewList result;

// Get the extension process's active views.

- ProcessManager* process_manager =

- ExtensionSystem::Get(GetProfile())->process_manager();

+ ProcessManager* process_manager = ProcessManager::Get(GetProfile());

GetInspectablePagesForExtensionProcess(

extension,

process_manager->GetRenderViewHostsForExtension(extension->id()),

@@ -590,8 +589,8 @@ ItemInspectViewList DeveloperPrivateGetItemsInfoFunction::

// app windows for incognito process.

if (service->profile()->HasOffTheRecordProfile() &&

IncognitoInfo::IsSplitMode(extension)) {

- process_manager = ExtensionSystem::Get(

- service->profile()->GetOffTheRecordProfile())->process_manager();

+ process_manager =

+ ProcessManager::Get(service->profile()->GetOffTheRecordProfile());

GetInspectablePagesForExtensionProcess(

extension,

process_manager->GetRenderViewHostsForExtension(extension->id()),