[Ozone] Properly initialize multitouch slot values

[Ozone] Properly initialize multitouch slot values

BUG=424363
NOTRY=true

Committed: https://crrev.com/826d0a0cc35014f243399625b53929af9a3773db
Cr-Commit-Position: refs/heads/master@{#300680}

[dnicoara, 2014-10-21 18:09:28]

dnicoara@chromium.org changed reviewers:
+ spang@chromium.org

[dnicoara, 2014-10-21 18:09:29]

PTAL

[spang, 2014-10-21 19:38:36]

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_device_info.cc (right):

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:16: struct MTSlotRequest {
For consistency: MtSlotRequest

(and everywhere else)

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:18: int32_t* values;
Should be an array.

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:68: return code - ABS_MT_SLOT - 1;
Can you make this a member function:

int32_t* slots = GetMtSlotsForCode(int code);

And DCHECK that code is within range.

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:123: for (unsigned int i = 0; i <
ABS_MT_COUNT; ++i) {
I think this should iterate over codes rather than the index. There's no reason
to have IndexToMTCode.

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_device_info.h (right):

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.h:16: #define ABS_MT_COUNT
(ABS_MT_TOOL_Y - ABS_MT_SLOT)
This looks deceptively like something that comes from input.h (and would collide
if they decide to add it). So please differentiate.

Maybe EVDEV_ABS_MT_COUNT

[dnicoara, 2014-10-21 20:32:12]

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_device_info.cc (right):

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:16: struct MTSlotRequest {
On 2014/10/21 19:38:36, spang wrote:
> For consistency: MtSlotRequest
> 
> (and everywhere else)

Removed the struct for simplicity.

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:68: return code - ABS_MT_SLOT - 1;
On 2014/10/21 19:38:36, spang wrote:
> Can you make this a member function:
> 
> int32_t* slots = GetMtSlotsForCode(int code);
> 
> And DCHECK that code is within range.

Done.

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.cc:123: for (unsigned int i = 0; i <
ABS_MT_COUNT; ++i) {
On 2014/10/21 19:38:36, spang wrote:
> I think this should iterate over codes rather than the index. There's no
reason
> to have IndexToMTCode.

Done.

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
File ui/events/ozone/evdev/event_device_info.h (right):

https://codereview.chromium.org/671723002/diff/20001/ui/events/ozone/evdev/ev...
ui/events/ozone/evdev/event_device_info.h:16: #define ABS_MT_COUNT
(ABS_MT_TOOL_Y - ABS_MT_SLOT)
On 2014/10/21 19:38:36, spang wrote:
> This looks deceptively like something that comes from input.h (and would
collide
> if they decide to add it). So please differentiate.
> 
> Maybe EVDEV_ABS_MT_COUNT

Done.

[spang, 2014-10-21 20:54:08]

lgtm

[dnicoara, 2014-10-22 15:07:46]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2014-10-22 15:08:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/671723002/160001

[commit-bot: I haz the power, 2014-10-22 15:09:59]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2014-10-22 15:10:57]

Patchset 9 (id:??) landed as
https://crrev.com/826d0a0cc35014f243399625b53929af9a3773db
Cr-Commit-Position: refs/heads/master@{#300680}

[dnicoara, 2014-10-22 15:19:14]

A revert of this CL (patchset #9 id:160001) has been created in
https://codereview.chromium.org/672633002/ by dnicoara@chromium.org.

The reason for reverting is: EVIOCGMTSLOTS isn't defined on some of the bots..