[Ozone] Properly initialize multitouch slot values

ui/events/ozone/evdev/event_device_info.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/events/ozone/evdev/event_device_info.h"
 
 #include <linux/input.h>
 
 #include "base/logging.h"
 #include "base/threading/thread_restrictions.h"
 
 namespace ui {
 
 namespace {
 
+struct MTSlotRequest {

[spang, 2014/10/21 19:38:36]

For consistency: MtSlotRequest

(and everywhere else)

[dnicoara, 2014/10/21 20:32:12]

Removed the struct for simplicity.

+  uint32_t code;
+  int32_t* values;

[spang, 2014/10/21 19:38:36]

Should be an array.

+};
+
 bool GetEventBits(int fd, unsigned int type, void* buf, unsigned int size) {
   if (ioctl(fd, EVIOCGBIT(type, size), buf) < 0) {
     DLOG(ERROR) << "failed EVIOCGBIT(" << type << ", " << size << ") on fd "
                 << fd;
     return false;
   }
 
   return true;
 }
 
 bool GetPropBits(int fd, void* buf, unsigned int size) {
   if (ioctl(fd, EVIOCGPROP(size), buf) < 0) {
     DLOG(ERROR) << "failed EVIOCGPROP(" << size << ") on fd " << fd;
     return false;
   }
 
   return true;
 }
 
 bool GetAbsInfo(int fd, int code, struct input_absinfo* absinfo) {
   if (ioctl(fd, EVIOCGABS(code), absinfo)) {
     DLOG(ERROR) << "failed EVIOCGABS(" << code << ") on fd " << fd;
     return false;
   }
   return true;
 }
 
+bool GetSlotValues(int fd, int code, int32_t* slot_values, unsigned int size) {
+  MTSlotRequest request;
+  request.code = code;
+  request.values = slot_values;
+
+  if (ioctl(fd,
+            EVIOCGMTSLOTS(sizeof(uint32_t) + sizeof(int32_t) * size),
+            &request) < 0) {
+    LOG(ERROR) << "failed EVIOCGMTSLOTS(" << code << ") on fd " << fd;
+    return false;
+  }
+
+  return true;
+}
+
+int IndexToMTCode(int index) {
+  return index + ABS_MT_SLOT + 1;
+}
+
+int MTCodeToIndex(int code) {
+  return code - ABS_MT_SLOT - 1;

[spang, 2014/10/21 19:38:36]

Can you make this a member function:

int32_t* slots = GetMtSlotsForCode(int code);

And DCHECK that code is within range.

[dnicoara, 2014/10/21 20:32:12]

Done.

+}
+
 }  // namespace
 
 EventDeviceInfo::EventDeviceInfo() {
   memset(ev_bits_, 0, sizeof(ev_bits_));
   memset(key_bits_, 0, sizeof(key_bits_));
   memset(rel_bits_, 0, sizeof(rel_bits_));
   memset(abs_bits_, 0, sizeof(abs_bits_));
   memset(msc_bits_, 0, sizeof(msc_bits_));
   memset(sw_bits_, 0, sizeof(sw_bits_));
   memset(led_bits_, 0, sizeof(led_bits_));
   memset(prop_bits_, 0, sizeof(prop_bits_));
   memset(abs_info_, 0, sizeof(abs_info_));
+  memset(slot_values_, 0, sizeof(slot_values_));
 }
 
-EventDeviceInfo::~EventDeviceInfo() {}
+EventDeviceInfo::~EventDeviceInfo() {
+  for (size_t i = 0; i < arraysize(slot_values_); ++i)
+    if (slot_values_[i])
+      delete[] slot_values_[i];
+}
 
 bool EventDeviceInfo::Initialize(int fd) {
   if (!GetEventBits(fd, 0, ev_bits_, sizeof(ev_bits_)))
     return false;
 
   if (!GetEventBits(fd, EV_KEY, key_bits_, sizeof(key_bits_)))
     return false;
 
   if (!GetEventBits(fd, EV_REL, rel_bits_, sizeof(rel_bits_)))
     return false;
@@ skipping 11 matching lines @@
     return false;
 
   if (!GetPropBits(fd, prop_bits_, sizeof(prop_bits_)))
     return false;
 
   for (unsigned int i = 0; i < ABS_CNT; ++i)
     if (HasAbsEvent(i))
       if (!GetAbsInfo(fd, i, &abs_info_[i]))
         return false;
 
+  int max_num_slots = abs_info_[ABS_MT_SLOT].maximum + 1;
+  for (unsigned int i = 0; i < ABS_MT_COUNT; ++i) {

[spang, 2014/10/21 19:38:36]

I think this should iterate over codes rather than the index. There's no reason
to have IndexToMTCode.

[dnicoara, 2014/10/21 20:32:12]

Done.

+    slot_values_[i] = new int32[max_num_slots];
+    memset(slot_values_[i], 0, sizeof(int32) * max_num_slots);
+    if (!GetSlotValues(fd, IndexToMTCode(i), slot_values_[i], max_num_slots))
+      return false;
+  }
+
   return true;
 }
 
 bool EventDeviceInfo::HasEventType(unsigned int type) const {
   if (type > EV_MAX)
     return false;
   return EvdevBitIsSet(ev_bits_, type);
 }
 
 bool EventDeviceInfo::HasKeyEvent(unsigned int code) const {
@@ skipping 39 matching lines @@
 }
 
 int32 EventDeviceInfo::GetAbsMinimum(unsigned int code) const {
   return abs_info_[code].minimum;
 }
 
 int32 EventDeviceInfo::GetAbsMaximum(unsigned int code) const {
   return abs_info_[code].maximum;
 }
 
+int32 EventDeviceInfo::GetSlotValue(unsigned int code,
+                                    unsigned int slot) const {
+  return slot_values_[MTCodeToIndex(code)][slot];
+}
+
 bool EventDeviceInfo::HasAbsXY() const {
   if (HasAbsEvent(ABS_X) && HasAbsEvent(ABS_Y))
     return true;
 
   if (HasAbsEvent(ABS_MT_POSITION_X) && HasAbsEvent(ABS_MT_POSITION_Y))
     return true;
 
   return false;
 }
 
@@ skipping 18 matching lines @@
   // Touchpads are not mapped to the screen.
   if (HasKeyEvent(BTN_LEFT) || HasKeyEvent(BTN_MIDDLE) ||
       HasKeyEvent(BTN_RIGHT) || HasKeyEvent(BTN_TOOL_FINGER))
     return false;
 
   // Touchscreens are mapped to the screen.
   return true;
 }
 
 }  // namespace ui