Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: content/shell/browser/shell_javascript_dialog_manager.h

Issue 671663002: Standardize usage of virtual/override/final in content/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/browser/shell_download_manager_delegate.h ('k') | content/shell/browser/shell_login_dialog.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/browser/shell_javascript_dialog_manager.h
diff --git a/content/shell/browser/shell_javascript_dialog_manager.h b/content/shell/browser/shell_javascript_dialog_manager.h
index 77cccd59ec8d63e3fb4df277772400424496e9b5..1e1f07b05e0b2cf2209b380603cc3a3be1e30cf5 100644
--- a/content/shell/browser/shell_javascript_dialog_manager.h
+++ b/content/shell/browser/shell_javascript_dialog_manager.h
@@ -17,29 +17,26 @@ class ShellJavaScriptDialog;
class ShellJavaScriptDialogManager : public JavaScriptDialogManager {
public:
ShellJavaScriptDialogManager();
- virtual ~ShellJavaScriptDialogManager();
+ ~ShellJavaScriptDialogManager() override;
// JavaScriptDialogManager:
- virtual void RunJavaScriptDialog(
- WebContents* web_contents,
- const GURL& origin_url,
- const std::string& accept_lang,
- JavaScriptMessageType javascript_message_type,
- const base::string16& message_text,
- const base::string16& default_prompt_text,
- const DialogClosedCallback& callback,
- bool* did_suppress_message) override;
-
- virtual void RunBeforeUnloadDialog(
- WebContents* web_contents,
- const base::string16& message_text,
- bool is_reload,
- const DialogClosedCallback& callback) override;
-
- virtual void CancelActiveAndPendingDialogs(
- WebContents* web_contents) override;
-
- virtual void WebContentsDestroyed(WebContents* web_contents) override;
+ void RunJavaScriptDialog(WebContents* web_contents,
+ const GURL& origin_url,
+ const std::string& accept_lang,
+ JavaScriptMessageType javascript_message_type,
+ const base::string16& message_text,
+ const base::string16& default_prompt_text,
+ const DialogClosedCallback& callback,
+ bool* did_suppress_message) override;
+
+ void RunBeforeUnloadDialog(WebContents* web_contents,
+ const base::string16& message_text,
+ bool is_reload,
+ const DialogClosedCallback& callback) override;
+
+ void CancelActiveAndPendingDialogs(WebContents* web_contents) override;
+
+ void WebContentsDestroyed(WebContents* web_contents) override;
// Called by the ShellJavaScriptDialog when it closes.
void DialogClosed(ShellJavaScriptDialog* dialog);
« no previous file with comments | « content/shell/browser/shell_download_manager_delegate.h ('k') | content/shell/browser/shell_login_dialog.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698