chrome/browser/gtk/browser_window_gtk.cc - Issue 67156: Fix regression I introduced where Stop/Go button would toggle state instantly...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/gtk/browser_window_gtk.cc

Issue 67156: Fix regression I introduced where Stop/Go button would toggle state instantly... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/gtk/browser_window_gtk.cc

===================================================================

--- chrome/browser/gtk/browser_window_gtk.cc (revision 13668)

+++ chrome/browser/gtk/browser_window_gtk.cc (working copy)

@@ -429,9 +429,9 @@

GetLocationBar()->FocusLocation();

}

-void BrowserWindowGtk::UpdateStopGoState(bool is_loading) {

+void BrowserWindowGtk::UpdateStopGoState(bool is_loading, bool force) {

toolbar_->GetGoButton()->ChangeMode(

- is_loading ? GoButtonGtk::MODE_STOP : GoButtonGtk::MODE_GO);

+ is_loading ? GoButtonGtk::MODE_STOP : GoButtonGtk::MODE_GO, force);

willchan no longer on Chromium 2009/04/15 18:23:46 Did you update GoButtonGtk::ChangeMode()? I don't

}

void BrowserWindowGtk::UpdateToolbar(TabContents* contents,

« no previous file with comments | « chrome/browser/gtk/browser_window_gtk.h ('k') | chrome/browser/views/frame/browser_view.h » ('j') | no next file with comments »