Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1648)

Unified Diff: chrome/browser/views/info_bubble.cc

Issue 67149: Fixes regression in painting info bubble. This is the result of... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/gfx/chrome_canvas.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/info_bubble.cc
===================================================================
--- chrome/browser/views/info_bubble.cc (revision 13665)
+++ chrome/browser/views/info_bubble.cc (working copy)
@@ -360,23 +360,24 @@
// Draw the border.
// Top border.
- canvas->DrawRectInt(kBorderColor1,
+ canvas->DrawLineInt(kBorderColor1,
kInfoBubbleCornerWidth, bubble_y,
- border_w,
- 0);
+ kInfoBubbleCornerWidth + border_w, bubble_y);
// Bottom border.
- canvas->DrawRectInt(kBorderColor1,
+ canvas->DrawLineInt(kBorderColor1,
kInfoBubbleCornerWidth, bubble_y + bubble_h - 1,
- border_w, 0);
+ kInfoBubbleCornerWidth + border_w,
+ bubble_y + bubble_h - 1);
// Left border.
- canvas->DrawRectInt(kBorderColor1,
+ canvas->DrawLineInt(kBorderColor1,
bubble_x, bubble_y + kInfoBubbleCornerHeight,
- 0, border_h);
+ bubble_x, bubble_y + kInfoBubbleCornerHeight + border_h);
// Right border.
- canvas->DrawRectInt(kBorderColor1,
+ canvas->DrawLineInt(kBorderColor1,
width() - 1, bubble_y + kInfoBubbleCornerHeight,
- 0, border_h);
Dean McNamee 2009/04/15 08:33:51 couldn't you have just changed all of these 0s to
sky 2009/04/15 14:44:22 That resulted in at least a two pixel line. To me
+ width() - 1,
+ bubble_y + kInfoBubbleCornerHeight + border_h);
// Draw the corners.
canvas->DrawBitmapInt(*kInfoBubbleCornerTopLeft, 0, bubble_y);
« no previous file with comments | « no previous file | chrome/common/gfx/chrome_canvas.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698